Refactor AES Instructions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 5 repliesIn review
- v16 patches 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | util: Add S-Box and InvS-Box Arrays to Common AES Utilsinclude/ util/ | +73 | 0 replies | |
| 2/6 | util: Add AES ShiftRows and InvShiftRows Tablesinclude/ util/ | +12 | 0 replies | |
| 3/6 | util: Add InvMixColumnsinclude/ util/ | +272 | 0 replies | |
| 4/6 | target-i386: Use Common ShiftRows and InvShiftRows Tablestarget-i386/ | +13 | 0 replies | |
| 5/6 | target-arm: Use Common Tables in AES Instructionstarget-arm/ | +4 | 0 replies | |
| 6/6 | target-ppc: Refactor AES Instructionstarget-ppc/ | +38 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [V2 PATCH 0/6] Refactor AES Instructions
This patch series addresses concerns raised by Richard Henderson regarding redundant copies of Advanced Encryption Standard (AES) data and code (see
http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html).
The patches declare commonly used AES tables in the include/qemu/aes.h header file and define the tables in util/aes.c, thus eliminating redundant copies.
Minor refactorization of the i386 and ARM instruction models are made to utilize this common support. The newly added PowerPC instructions are completely rewritten and look much more like the i386 equivalents; a substantial amount of code is eliminated.
V2: updated patch 05/06 per Richard Henderson's review (const pointer to const)
Tom Musta (6):
util: Add S-Box and InvS-Box Arrays to Common AES Utils
util: Add AES ShiftRows and InvShiftRows Tables
util: Add InvMixColumns
target-i386: Use Common ShiftRows and InvShiftRows Tables
target-arm: Use Common Tables in AES Instructions
target-ppc: Refactor AES Instructions
include/qemu/aes.h | 14 ++ target-arm/crypto_helper.c | 79 +---------- target-i386/ops_sse.h | 32 ++--- target-ppc/int_helper.c | 292 +++++-------------------------------- util/aes.c | 343 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 412 insertions(+), 348 deletions(-)