iio: Minor cleanups to spear ADC driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 11 repliesIn review
- v24 patches 11 repliesSuperseded
- v15 patches 5 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | staging:iio:adc:spear adc - prefix defines to avoid namespace clashes.drivers/ | +36 | 2 replies | |
| 2/6 | staging:iio:adc:spear_adc drop initialization of unused scan_typedrivers/ | +0 | 2 replies | |
| 3/6 | staging:iio:adc:spear_adc use info_mask_shared_by_all for samp freqdrivers/ | +33 | 2 replies | |
| 4/6 | staging:iio:adc:spear rename device specific state structure to _statedrivers/ | +63 | 2 replies | |
| 5/6 | staging:iio:adc:spear rename iodev -> indio_dev to fit with current conventiondrivers/ | +15 | 1 reply | |
| 6/6 | staging:iio:adc:spear rename spear_read_raw to spear_adc_read_rawdrivers/ | +5 | 2 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Stefan Roese | Hartmut Knaack |
|---|---|---|
| 1/6 | A-b | A-b |
| 2/6 | A-b | |
| 3/6 | A-b | A-b |
| 4/6 | A-b | |
| 5/6 | A-b | |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V3 0/6] iio: Minor cleanups to spear ADC driver
Note that Hartmut Knaack has highlighted some additional improvements to be made to this driver, but to keep things manageable I'm proposing the following initial set and second series to make the other changes and move the driver out of staging.
Changes since V1. Fixed the issues Harmuk Knaack pointed out in patch 4 by dropping the unused variables and ensure mask was as it should be.
Previous description:
This driver has been reasonably clean since it was first merged within the staging tree. If it had been submitted after the IIO core was outside of staging we might have taken it as is. I did a final review and the first 4 patches of this series rework various minor aspects of the driver.
Whilst it is a slow driver, the device tree matches at the lowest level seemed a little unwise so the largest rework is concerned with centralising that logic using a classic ops structure of function pointers. The other large change was to move to using the info_mask_shared_by_all approach to handle sampling frequency. This is something I am slowly propogating across the whole tree, but might as well be done whilst we are looking at this driver.
I don't have hardware and whilst I think these are all changes that are possible to easily verify by eye, a tested by would be most welcome!
Note this is the first driver I'm suggesting moving out of staging following Greg's entirely reasonable question of 'What's wrong with the stuff that is left?' Any help with this sort of final cleanup and move would be most welcome.
Jonathan
Jonathan Cameron (6):
staging:iio:adc:spear adc - prefix defines to avoid namespace clashes. staging:iio:adc:spear_adc drop initialization of unused scan_type staging:iio:adc:spear_adc use info_mask_shared_by_all for samp freq staging:iio:adc:spear rename device specific state structure to _state staging:iio:adc:spear rename iodev -> indio_dev to fit with current
convention
staging:iio:adc:spear rename spear_read_raw to spear_adc_read_raw
drivers/staging/iio/adc/spear_adc.c | 313 ++++++++++++++++-------------------- 1 file changed, 141 insertions(+), 172 deletions(-)
Signature · 1 line
1.9.0