Skip to content

Fix index regression in nand_read_subpage

Ron linux-mtd 1 version Applied

Status from this message: Pushed to l2-mtd.git. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2Fix index regression in nand_read_subpagedrivers/mtd/nand/nand_base.c+2 -34 replies
2/2Use the nand_read_subpage index everywheredrivers/mtd/nand/nand_base.c+1 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix index regression in nand_read_subpage

Hi,

I stumbled across this while reviewing changes to the code by eye, and I'm a bit surprised that it seems to have gone unnoticed so far but unless I'm missing something obvious, the "clean up" changes in 7351d3a5dbf4 really did alter the previous behaviour, which I think was correct (or if it wasn't then I'm surprised _it_ went unnoticed for as long as it did!).

I haven't actually been bitten by it myself either way (I'm currently bashing on issues in u-boot, and spotted this while comparing it with the latest kernel code), but I figured I'd pass it along for review.

Patch is against Linus' master a4ecdf82f8ea49f7d3a07.

Cheers,
Ron