Skip to content

Stop reinit of XBZRLE.lock

Dr. David Alan Gilbert (git) qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v11 patch 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Provide init function for ram migrationarch_init.c include/migration/migration.h include/sysemu/arch_init.h +1 more+8 -51 reply
2/2Init the XBZRLE.lock in ram_mig_initarch_init.c+31 -301 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGongleiMarkus Armbruster
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock

From: "Dr. David Alan Gilbert" <[email protected]>

Markus Armbruster spotted that the XBZRLE.lock might get initalised multiple times in the case of a second attempted migration, and that's undefined behaviour for pthread_mutex_init.

This patchset is based on Markus' proto-patch in the discussions off v1.

--
v2
Rework completely based on Markus's patch

Dr. David Alan Gilbert (2):
Provide init function for ram migration
Init the XBZRLE.lock in ram_mig_init

 arch_init.c                   | 68 +++++++++++++++++++++++--------------------
 include/migration/migration.h |  2 --
 include/sysemu/arch_init.h    |  1 +
 vl.c                          |  3 +-
 4 files changed, 39 insertions(+), 35 deletions(-)
Signature · 1 line
1.8.5.3