Abort blkid probing errors
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 2 repliesApplied
- v22 patches 5 repliesSuperseded
- v12 patches 0 repliesSuperseded
Changes to v1 from the cover letter
- Fixup issues found when running 'make check'
- Only fail for I/O errors
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | blkid: stop scanning on I/O errorlibblkid/ libblkid/ libblkid/ +1 more | +78 | 1 reply | |
| 2/2 | blkid: convert superblocks to new calling conventionlibblkid/ libblkid/ libblkid/ +53 more | +357 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCHv3 0/2] Abort blkid probing errors
Whenever blkid incurs an error during probing it should abort all probes, as any result will be bogus anyway. Plus blkid will taking ages to complete on faulty devices, stalling the uevent queue and resulting in udev killing the process eventually.
With this patch the number of I/O errors during
blkid run is cut from 156 to just 2.
Changes to v1:
- Fixup issues found when running 'make check'
- Only fail for I/O errors
Changes to v2:
- Return error code instead of -1
- Correctly terminate probing loop
- Return correct error code when probing partitions
Hannes Reinecke (2):
blkid: stop scanning on I/O error
blkid: convert superblocks to new calling convention
libblkid/src/blkidP.h | 3 ++ libblkid/src/partitions/aix.c | 2 +- libblkid/src/partitions/bsd.c | 28 ++++++++++------- libblkid/src/partitions/dos.c | 40 ++++++++++++++---------- libblkid/src/partitions/gpt.c | 29 ++++++++++++------ libblkid/src/partitions/mac.c | 25 ++++++++++----- libblkid/src/partitions/minix.c | 17 +++++----- libblkid/src/partitions/partitions.c | 44 ++++++++++++++------------ libblkid/src/partitions/sgi.c | 15 +++++---- libblkid/src/partitions/solaris_x86.c | 15 +++++---- libblkid/src/partitions/sun.c | 17 +++++----- libblkid/src/partitions/ultrix.c | 15 +++++---- libblkid/src/partitions/unixware.c | 15 +++++---- libblkid/src/probe.c | 30 +++++++++++++++--- libblkid/src/superblocks/adaptec_raid.c | 15 ++++----- libblkid/src/superblocks/bcache.c | 4 +-- libblkid/src/superblocks/befs.c | 26 ++++++++-------- libblkid/src/superblocks/btrfs.c | 2 +- libblkid/src/superblocks/cramfs.c | 2 +- libblkid/src/superblocks/ddf_raid.c | 19 +++++++----- libblkid/src/superblocks/drbd.c | 8 ++--- libblkid/src/superblocks/drbdproxy_datalog.c | 2 +- libblkid/src/superblocks/exfat.c | 4 ++- libblkid/src/superblocks/ext.c | 30 +++++++++--------- libblkid/src/superblocks/f2fs.c | 2 +- libblkid/src/superblocks/gfs.c | 8 ++--- libblkid/src/superblocks/hfs.c | 12 ++++---- libblkid/src/superblocks/highpoint_raid.c | 12 ++++---- libblkid/src/superblocks/hpfs.c | 8 ++--- libblkid/src/superblocks/iso9660.c | 4 +-- libblkid/src/superblocks/isw_raid.c | 13 ++++---- libblkid/src/superblocks/jfs.c | 2 +- libblkid/src/superblocks/jmicron_raid.c | 13 ++++---- libblkid/src/superblocks/linux_raid.c | 46 ++++++++++++++++------------ libblkid/src/superblocks/lsi_raid.c | 10 +++--- libblkid/src/superblocks/luks.c | 2 +- libblkid/src/superblocks/lvm.c | 6 ++-- libblkid/src/superblocks/minix.c | 18 ++++++----- libblkid/src/superblocks/netware.c | 2 +- libblkid/src/superblocks/nilfs.c | 4 +-- libblkid/src/superblocks/ntfs.c | 6 ++-- libblkid/src/superblocks/nvidia_raid.c | 12 ++++---- libblkid/src/superblocks/ocfs.c | 8 ++--- libblkid/src/superblocks/promise_raid.c | 10 +++--- libblkid/src/superblocks/reiserfs.c | 8 ++--- libblkid/src/superblocks/romfs.c | 2 +- libblkid/src/superblocks/silicon_raid.c | 10 +++--- libblkid/src/superblocks/squashfs.c | 2 +- libblkid/src/superblocks/superblocks.c | 38 +++++++++++++++-------- libblkid/src/superblocks/swap.c | 24 +++++++-------- libblkid/src/superblocks/sysv.c | 8 ++--- libblkid/src/superblocks/ubifs.c | 2 +- libblkid/src/superblocks/udf.c | 16 +++++----- libblkid/src/superblocks/ufs.c | 4 +-- libblkid/src/superblocks/vfat.c | 16 +++++----- libblkid/src/superblocks/via_raid.c | 6 ++-- libblkid/src/superblocks/vmfs.c | 4 +-- libblkid/src/superblocks/vxfs.c | 2 +- libblkid/src/superblocks/xfs.c | 6 ++-- libblkid/src/superblocks/zfs.c | 6 ++-- 60 files changed, 435 insertions(+), 324 deletions(-)
Signature · 1 line
1.7.12.4