Skip to content

em28xx: clean up the main device struct and move sub-module specific data to its own data structs

Frank Schäfer linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19em28xx: move sub-module data structs to a common place in the main structdrivers/media/usb/em28xx/em28xx.h+5 -60 replies
2/19em28xx-video: simplify usage of the pointer to struct v4l2_ctrl_handler in em28xx_v4l2_init()drivers/media/usb/em28xx/em28xx-video.c+14 -140 replies
3/19em28xx: start moving em28xx-v4l specific data to its own structdrivers/media/usb/em28xx/em28xx-camera.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+116 -563 replies
4/19em28xx: move struct v4l2_ctrl_handler ctrl_handler from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+11 -50 replies
5/19em28xx: move struct v4l2_clk *clk from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-camera.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+10 -90 replies
6/19em28xx: move video_device structs from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+56 -713 replies
7/19em28xx: move videobuf2 related data from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+15 -140 replies
8/19em28xx: move v4l2 frame resolutions and scale data from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-vbi.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+61 -450 replies
9/19em28xx: move vinmode and vinctrl data from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-camera.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+16 -160 replies
10/19em28xx: move TV norm from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+21 -170 replies
11/19em28xx: move struct em28xx_fmt *format from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+8 -90 replies
12/19em28xx: move progressive/interlaced fields from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+22 -170 replies
13/19em28xx: move sensor parameter fields from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-camera.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+20 -160 replies
14/19em28xx: move capture state tracking fields from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+29 -280 replies
15/19em28xx: move v4l2 user counting fields from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+18 -140 replies
16/19em28xx: move tuner frequency field from struct em28xx to struct v4l2drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+11 -80 replies
17/19em28xx: remove field tda9887_conf from struct em28xxdrivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+3 -70 replies
18/19em28xx: remove field tuner_addr from struct em28xxdrivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-video.c drivers/media/usb/em28xx/em28xx.h+8 -120 replies
19/19em28xx: move fields wq_trigger and streaming_started from struct em28xx to struct em28xx_audiodrivers/media/usb/em28xx/em28xx-audio.c drivers/media/usb/em28xx/em28xx.h+25 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] em28xx: clean up the main device struct and move sub-module specific data to its own data structs

This patch series cleans up the main device struct of the em28xx driver.

Most of the patches (patches 3-16) are about moving the em28xx-v4l specific data to it's own dynamically allocated data structure.
Patch 19 moves two em28xx-alsa specific fields to the em28xx_audio struct. Patches 17 and 18 remove two fields which aren't needed.

Frank Schäfer (19):
em28xx: move sub-module data structs to a common place in the main
struct
em28xx-video: simplify usage of the pointer to struct

    v4l2_ctrl_handler in em28xx_v4l2_init()
  em28xx: start moving em28xx-v4l specific data to its own struct
  em28xx: move struct v4l2_ctrl_handler ctrl_handler from struct em28xx
    to struct v4l2
  em28xx: move struct v4l2_clk *clk from struct em28xx to struct v4l2
  em28xx: move video_device structs from struct em28xx to struct v4l2
  em28xx: move videobuf2 related data from struct em28xx to struct v4l2
  em28xx: move v4l2 frame resolutions and scale data from struct em28xx
    to struct v4l2
  em28xx: move vinmode and vinctrl data from struct em28xx to struct
    v4l2
  em28xx: move TV norm from struct em28xx to struct v4l2
  em28xx: move struct em28xx_fmt *format from struct em28xx to struct
    v4l2
  em28xx: move progressive/interlaced fields from struct em28xx to
    struct v4l2
  em28xx: move sensor parameter fields from struct em28xx to struct v4l2
  em28xx: move capture state tracking fields from struct em28xx to
    struct v4l2
  em28xx: move v4l2 user counting fields from struct em28xx to struct
    v4l2

em28xx: move tuner frequency field from struct em28xx to struct v4l2
em28xx: remove field tda9887_conf from struct em28xx
em28xx: remove field tuner_addr from struct em28xx
em28xx: move fields wq_trigger and streaming_started from struct
em28xx to struct em28xx_audio

 drivers/media/usb/em28xx/em28xx-audio.c  |  39 +-
 drivers/media/usb/em28xx/em28xx-camera.c |  51 +--
 drivers/media/usb/em28xx/em28xx-cards.c  |   9 -
 drivers/media/usb/em28xx/em28xx-vbi.c    |  10 +-
 drivers/media/usb/em28xx/em28xx-video.c  | 592 +++++++++++++++++--------------
 drivers/media/usb/em28xx/em28xx.h        | 120 ++++---
 6 files changed, 452 insertions(+), 369 deletions(-)
Signature · 1 line
1.8.4.5