Skip to content

OMAP SSI driver / N900 modem support

Sebastian Reichel linux-devicetree linux-omap lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 13 repliesIn review
  2. v413 patches 0 repliesSuperseded
  3. v314 patches 27 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10HSI: method to unregister clients from an hsi portdrivers/hsi/hsi.c include/linux/hsi/hsi.h+11 -00 replies
2/10HSI: Add channel resource support to HSI clientsdrivers/hsi/clients/hsi_char.c drivers/hsi/hsi.c include/linux/hsi/hsi.h+71 -110 replies
3/10HSI: export method to (un)register clientsdrivers/hsi/hsi.c include/linux/hsi/hsi.h+11 -30 replies
4/10HSI: Add common DT binding for HSI client devicesDocumentation/devicetree/bindings/hsi/client-devices.txt drivers/hsi/hsi.c include/linux/hsi/hsi.h+261 -20 replies
5/10HSI: Introduce OMAP SSI driverdrivers/hsi/Kconfig drivers/hsi/Makefile drivers/hsi/controllers/Kconfig +5 more+2388 -00 replies
6/10Documentation: DT: omap-ssi binding documentationDocumentation/devicetree/bindings/hsi/omap-ssi.txt+97 -00 replies
7/10HSI: Introduce driver for SSI Protocoldrivers/hsi/clients/Kconfig drivers/hsi/clients/Makefile drivers/hsi/clients/ssi_protocol.c +1 more+1243 -10 replies
8/10HSI: Introduce Nokia N900 modem driverDocumentation/devicetree/bindings/hsi/nokia-modem.txt drivers/hsi/clients/Kconfig drivers/hsi/clients/Makefile +1 more+352 -00 replies
9/10DTS: ARM: OMAP3-N900: Add SSI supportarch/arm/boot/dts/omap3-n900.dts arch/arm/boot/dts/omap3.dtsi arch/arm/boot/dts/omap34xx.dtsi +1 more+91 -012 replies
10/10DTS: ARM: OMAP3-N900: Add modem supportarch/arm/boot/dts/omap3-n900.dts+42 -11 reply

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchPavel MachekIvaylo DimitrovSebastian Reichel
1/10R-b T-b
2/10T-b
3/10R-b T-b
4/10R-b T-b
5/10T-b
6/10R-b
7/10T-b
8/10R-b T-b
9/10R-b T-b A-b
10/10R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCHv5 00/10] OMAP SSI driver / N900 modem support

Hi,

This is the ninth round of the OMAP SSI driver patches. I plan to move all the whole patchset (except DTS changes) to for-next on 2014-05-15 23:42 if nobody objects until then. @Tony: Is this sufficiently early to get the DTS changes into 3.16 via your tree?

Changes since PATCHv4 [0]:
* Removed first three patches (HSI Documentation, MAINTAINER file update and hsi-char fix) from the patchset. I added them to for-next already.
* Added module parameter pm to the nokia-modem kernel module, which can be used to disable requesting the gpios (needed by fremantle). The same parameter will be used later to enable full-kernel based power management. This is not yet implemented in the driver and would break all existing userspace applications.
* Added Tested-By from Ivaylo Dimitrov, who successfully tested it with Maemo fremantle (with some additional patches not directly touching the modem, but needed to boot Maemo).
* Export ssi-protocol reset function, so that nokia-n900 can call it if ssi-protocol is built as module.
* Updated KConfig, so that n900-modem / ssi-protocol and omap-ssi can be built independently.
* Updated KConfig omap-ssi entry to depend on omap3 or compile-test.
* Fix build for disabled CONFIG_OF

For testing you can either apply this patchset to current mainline kernel or use the n900-modem-support-4 branch available on [1]. Feedback is highly appreciated :)

For testing the patchset you should build the kernel with all config entries in the HSI subsystem activated and boot using the updated device tree information (platform data based booting is not supported!). Testing the patchset with ofono works like this:

 # provide cmt device for ofono
 ln -sf /sys/bus/hsi/n900-modem /dev/cmt
 # start ofono
 ofono --nodetach --debug
 # enable the modem
 mdbus2 -s org.ofono /n900_0 org.ofono.Modem.SetProperty Powered true
 # enable modem's RF parts
 mdbus2 -s org.ofono /n900_0 org.ofono.Modem.SetProperty Online true
 # scan for available networks (takes some time)
 mdbus2 -s org.ofono /n900_0 org.ofono.NetworkRegistration.Scan

TODO (post-merge):
* Central Message Queue in HSI framework
* Remove the hwmod DT hack
* Implement proper context loss detection
* Implement full N900 modem PM (in-kernel)
* Remove wakeline checks (thus removing the FIXMEs)

[0] https://lkml.org/lkml/2014/4/25/520
[1] git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git

-- Sebastian

Sebastian Reichel (10):
HSI: method to unregister clients from an hsi port
HSI: Add channel resource support to HSI clients
HSI: export method to (un)register clients
HSI: Add common DT binding for HSI client devices
HSI: Introduce OMAP SSI driver
Documentation: DT: omap-ssi binding documentation
HSI: Introduce driver for SSI Protocol
HSI: Introduce Nokia N900 modem driver
DTS: ARM: OMAP3-N900: Add SSI support
DTS: ARM: OMAP3-N900: Add modem support

 .../devicetree/bindings/hsi/client-devices.txt     |   44 +
 .../devicetree/bindings/hsi/nokia-modem.txt        |   57 +
 Documentation/devicetree/bindings/hsi/omap-ssi.txt |   97 ++
 arch/arm/boot/dts/omap3-n900.dts                   |   65 +
 arch/arm/boot/dts/omap3.dtsi                       |   45 +
 arch/arm/boot/dts/omap34xx.dtsi                    |   11 +
 arch/arm/boot/dts/omap36xx.dtsi                    |   11 +
 drivers/hsi/Kconfig                                |    1 +
 drivers/hsi/Makefile                               |    1 +
 drivers/hsi/clients/Kconfig                        |   17 +
 drivers/hsi/clients/Makefile                       |    4 +-
 drivers/hsi/clients/hsi_char.c                     |   12 +-
 drivers/hsi/clients/nokia-modem.c                  |  285 ++++
 drivers/hsi/clients/ssi_protocol.c                 | 1191 +++++++++++++++++
 drivers/hsi/controllers/Kconfig                    |   19 +
 drivers/hsi/controllers/Makefile                   |    6 +
 drivers/hsi/controllers/omap_ssi.c                 |  625 +++++++++
 drivers/hsi/controllers/omap_ssi.h                 |  166 +++
 drivers/hsi/controllers/omap_ssi_port.c            | 1399 ++++++++++++++++++++
 drivers/hsi/controllers/omap_ssi_regs.h            |  171 +++
 drivers/hsi/hsi.c                                  |  275 +++-
 include/linux/hsi/hsi.h                            |   39 +-
 include/linux/hsi/ssi_protocol.h                   |   42 +
 23 files changed, 4566 insertions(+), 17 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hsi/client-devices.txt
 create mode 100644 Documentation/devicetree/bindings/hsi/nokia-modem.txt
 create mode 100644 Documentation/devicetree/bindings/hsi/omap-ssi.txt
 create mode 100644 drivers/hsi/clients/nokia-modem.c
 create mode 100644 drivers/hsi/clients/ssi_protocol.c
 create mode 100644 drivers/hsi/controllers/Kconfig
 create mode 100644 drivers/hsi/controllers/Makefile
 create mode 100644 drivers/hsi/controllers/omap_ssi.c
 create mode 100644 drivers/hsi/controllers/omap_ssi.h
 create mode 100644 drivers/hsi/controllers/omap_ssi_port.c
 create mode 100644 drivers/hsi/controllers/omap_ssi_regs.h
 create mode 100644 include/linux/hsi/ssi_protocol.h
Signature · 1 line
2.0.0.rc0