Skip to content

ILK+ interrupt improvements, v3

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/i915: add GEN5_IRQ_INIT macrodrivers/gpu/drm/i915/i915_irq.c+10 -140 replies
2/19drm/i915: also use GEN5_IRQ_INIT with south display interruptsdrivers/gpu/drm/i915/i915_irq.c+1 -20 replies
3/19drm/i915: use GEN8_IRQ_INIT on GEN5drivers/gpu/drm/i915/i915_irq.c+19 -270 replies
4/19drm/i915: add GEN5_IRQ_FINIdrivers/gpu/drm/i915/i915_irq.c+9 -90 replies
5/19drm/i915: don't forget to uninstall the PM IRQsdrivers/gpu/drm/i915/i915_irq.c+2 -00 replies
6/19drm/i915: properly clear IIR at irq_uninstall on Gen5+drivers/gpu/drm/i915/i915_irq.c+27 -500 replies
7/19drm/i915: add GEN5_IRQ_INITdrivers/gpu/drm/i915/i915_irq.c+19 -180 replies
8/19drm/i915: check if IIR is still zero at postinstall on Gen5+drivers/gpu/drm/i915/i915_irq.c+20 -170 replies
9/19drm/i915: fix SERR_INT init/reset codedrivers/gpu/drm/i915/i915_irq.c+7 -60 replies
10/19drm/i915: fix GEN7_ERR_INT init/reset codedrivers/gpu/drm/i915/i915_irq.c+4 -30 replies
11/19drm/i915: fix open coded gen5_gt_irq_preinstalldrivers/gpu/drm/i915/i915_irq.c+4 -60 replies
12/19drm/i915: extract ibx_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+14 -70 replies
13/19drm/i915: call ibx_irq_uninstall from gen8_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+2 -00 replies
14/19drm/i915: enable SDEIER laterdrivers/gpu/drm/i915/i915_irq.c+21 -60 replies
15/19drm/i915: remove ibx_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+5 -180 replies
16/19drm/i915: add missing intel_hpd_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+2 -00 replies
17/19drm/i915: add ironlake_irq_resetdrivers/gpu/drm/i915/i915_irq.c+11 -100 replies
18/19drm/i915: add gen8_irq_resetdrivers/gpu/drm/i915/i915_irq.c+8 -190 replies
19/19drm/i915: only enable HWSTAM interrupts on postinstall on ILK+drivers/gpu/drm/i915/i915_irq.c+4 -68 replies

Reviews trailers per patch

11 of 19 patches have a Reviewed-by or Acked-by.

PatchBen Widawsky
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19
7/19R-b
8/19
9/19R-b
10/19R-b
11/19
12/19R-b
13/19R-b
14/19
15/19
16/19R-b
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/19] ILK+ interrupt improvements, v3

From: Paulo Zanoni <[email protected]>

Hi

This is a follow up to "ILK+ interrupt improvements, v3", which was reveiwed by Ben.

The biggest difference is that patch 20 was squashed into the previous patch, so different patches received different chunks of patch 20. This caused the need to rebase pretty much every patch of the series. There were also some small changes, like typos on commit messages, changes on comments and the removal of some assertions.

We had some discussions regarding renaming, where Ben proposed renames but Daniel disagreed with the proposals. Ben expressed he was not comfortable with giving Reviewed-by tags on some patches without the renames and I understand his point of view, so I just did not add the tags for those patches. The patches that still do not have Reviewed-by tags are: 6, 8, 11, 14, 15, 17, 18, 19.

Thanks,
Paulo

Paulo Zanoni (19):
drm/i915: add GEN5_IRQ_INIT macro
drm/i915: also use GEN5_IRQ_INIT with south display interrupts drm/i915: use GEN8_IRQ_INIT on GEN5
drm/i915: add GEN5_IRQ_FINI
drm/i915: don't forget to uninstall the PM IRQs drm/i915: properly clear IIR at irq_uninstall on Gen5+ drm/i915: add GEN5_IRQ_INIT
drm/i915: check if IIR is still zero at postinstall on Gen5+ drm/i915: fix SERR_INT init/reset code
drm/i915: fix GEN7_ERR_INT init/reset code
drm/i915: fix open coded gen5_gt_irq_preinstall drm/i915: extract ibx_irq_uninstall
drm/i915: call ibx_irq_uninstall from gen8_irq_uninstall drm/i915: enable SDEIER later
drm/i915: remove ibx_irq_uninstall
drm/i915: add missing intel_hpd_irq_uninstall drm/i915: add ironlake_irq_reset
drm/i915: add gen8_irq_reset
drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

 drivers/gpu/drm/i915/i915_irq.c | 281 ++++++++++++++++++----------------------
 1 file changed, 126 insertions(+), 155 deletions(-)
Signature · 1 line
1.8.5.3