Skip to content

Fix if multiple SDVO outputs are flagged

Egbert Eich intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/i915: Only break encoder linked when linked to connectordrivers/gpu/drm/i915/intel_display.c+2 -08 replies
2/2drm/i915: Set up SDVO encoder type only at detectdrivers/gpu/drm/i915/intel_sdvo.c+18 -56 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchChris WilsonDaniel Vetter
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Fix if multiple SDVO outputs are flagged

Currently the i915 driver can only handle well if only a single SDVO output is flagged (ie output_flags has only one bit set). If multiple outputs are flagged the side effects are only cosmetic in most cases (ie. the encoder may have the wrong type set), but there are situations (namely when intel_connector_break_all_links() is called) where this may lead to an inconsistent driver state.

The following two patches fix both situations.

Egbert Eich (2):
drm/i915: Only break encoder linked when linked to connector drm/i915: Set up SDVO encoder type only at detect

 drivers/gpu/drm/i915/intel_display.c |  2 ++
 drivers/gpu/drm/i915/intel_sdvo.c    | 23 ++++++++++++++++++-----
 2 files changed, 20 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.4.5