Skip to content

xfs: tmpfile fixes

Brian Foster linux-fsdevel linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 12 repliesIn review

Changes in v3 from the cover letter

- Split up the deadlock fix and inode security initialization into separate patches. [hch]
- Dropped the default ACL and associated refactor bits for now. [hch]
- Split the xfs_create() tres and xfs_create_tmpfile() cleanups into separate patches. [hch]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xfs: fix tmpfile/selinux ilock deadlockfs/xfs/xfs_inode.c fs/xfs/xfs_inode.h fs/xfs/xfs_iops.c+16 -81 reply
2/4xfs: initialize inode security on tmpfile creationfs/xfs/xfs_iops.c+6 -08 replies
3/4xfs: replace on-stack xfs_trans_res with pointer in xfs_create()fs/xfs/xfs_inode.c+6 -91 reply
4/4xfs: fold xfs_create_tmpfile() into xfs_create()fs/xfs/xfs_inode.c fs/xfs/xfs_inode.h fs/xfs/xfs_iops.c +1 more+47 -1421 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/4R-b
2/4
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] xfs: tmpfile fixes

Hi all,

Here's a v3 series for the patches previously posted here:

http://oss.sgi.com/archives/xfs/2014-04/msg00181.html

Patches 1 and 2 are just a split-up of the v1 patch:

http://oss.sgi.com/archives/xfs/2014-04/msg00149.html

Note the v1 patch has a reviewed-by, so feel free to drop 1 and 2 here in favor of that version. Patches 3 and 4 are a couple cleanups in the xfs_create() path.

Setting the default ACL is dropped until it is determined how that should be handled for tmpfile(). This means the xfs_iops.c refactor bits have been dropped as well.

Brian

v3:
- Split up the deadlock fix and inode security initialization into separate patches. [hch]
- Dropped the default ACL and associated refactor bits for now. [hch]
- Split the xfs_create() tres and xfs_create_tmpfile() cleanups into separate patches. [hch]
v2:
- Added a generic create helper to inherit the security/acl init. code in the tmpfile path.
- Added patch 2 to fold xfs_create_tmpfile() into xfs_create().

Brian Foster (4):
xfs: fix tmpfile/selinux ilock deadlock
xfs: initialize inode security on tmpfile creation
xfs: replace on-stack xfs_trans_res with pointer in xfs_create()
xfs: fold xfs_create_tmpfile() into xfs_create()

 fs/xfs/xfs_inode.c | 193 +++++++++++++----------------------------------------
 fs/xfs/xfs_inode.h |   2 -
 fs/xfs/xfs_iops.c  |  20 +++++-
 fs/xfs/xfs_trace.h |   7 +-
 4 files changed, 69 insertions(+), 153 deletions(-)
Signature · 6 lines
1.8.3.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs