Skip to content

Introduce drivers/soc and add QCOM GSBI driver

Andy Gross linux-arm-kernel linux-arm-msm linux-devicetree lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v14 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Add dt-bindings file containing definitions for MUX values
- Fix code comments
- Removed unnecessary code

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4soc: Placeholder files for drivers/socdrivers/Kconfig drivers/Makefile drivers/soc/Kconfig+10 -02 replies
2/4soc: qcom: Add device tree binding for GSBIDocumentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt include/dt-bindings/soc/qcom,gsbi.h+104 -00 replies
3/4soc: qcom: Add GSBI driverdrivers/soc/Kconfig drivers/soc/Makefile drivers/soc/qcom/Kconfig +2 more+103 -11 reply
4/4tty: serial: msm: Remove direct access to GSBIdrivers/tty/serial/msm_serial.c drivers/tty/serial/msm_serial.h+2 -513 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Patch v2 0/4] Introduce drivers/soc and add QCOM GSBI driver

The first patch in this set adds the drivers/soc directory and all the necessary plumbing. These changes were discussed at the kernel summit and also were introduced in an earlier patch set from Santosh Shilimkar.

Reference the following set of patches:
https://lkml.org/lkml/2014/2/28/567

The remaining patches add the QCOM GSBI (General Serial Bus Interface) driver, device tree binding information for both the GSBI and child node interaction, and lastly a patch to fix the current MSM serial driver to work correctly with the GSBI changes.

Before this patch series, serial drivers (UART, I2C, and SPI) were all directly accessing the overarching mux control settings for the parent GSBI device. This leads to unfortunate interactions when you want a UART and I2C device which share the same GSBI interface. By moving the serial devices to child nodes of the GSBI, we can get the right mode setting for the ports and keep the children from accessing the GSBI directly.

Changes from v1:
- Add dt-bindings file containing definitions for MUX values
- Fix code comments
- Removed unnecessary code

Andy Gross (4):
soc: Placeholder files for drivers/soc
soc: qcom: Add device tree binding for GSBI
soc: qcom: Add GSBI driver
tty: serial: msm: Remove direct access to GSBI

 .../devicetree/bindings/soc/qcom/qcom,gsbi.txt     |   78 ++++++++++++++++++
 drivers/Kconfig                                    |    2 +
 drivers/Makefile                                   |    4 +
 drivers/soc/Kconfig                                |    5 ++
 drivers/soc/Makefile                               |    5 ++
 drivers/soc/qcom/Kconfig                           |   11 +++
 drivers/soc/qcom/Makefile                          |    1 +
 drivers/soc/qcom/qcom_gsbi.c                       |   84 ++++++++++++++++++++
 drivers/tty/serial/msm_serial.c                    |   48 +----------
 drivers/tty/serial/msm_serial.h                    |    5 --
 include/dt-bindings/soc/qcom,gsbi.h                |   26 ++++++
 11 files changed, 218 insertions(+), 51 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/Makefile
 create mode 100644 drivers/soc/qcom/Kconfig
 create mode 100644 drivers/soc/qcom/Makefile
 create mode 100644 drivers/soc/qcom/qcom_gsbi.c
 create mode 100644 include/dt-bindings/soc/qcom,gsbi.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation