Skip to content

Semaphores again. Needs shepherd.

Ben Widawsky intel-gfx 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915: Make semaphore updates more precisedrivers/gpu/drm/i915/intel_ringbuffer.c+9 -160 replies
2/10drm/i915: gen specific ring initdrivers/gpu/drm/i915/intel_ringbuffer.c+149 -760 replies
3/10drm/i915/bdw: implement semaphore signaldrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+190 -600 replies
4/10drm/i915/bdw: implement semaphore waitdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+34 -60 replies
5/10drm/i915: Implement MI decode for gen8drivers/gpu/drm/i915/i915_irq.c+5 -60 replies
6/10drm/i915: Extract semaphore error collectiondrivers/gpu/drm/i915/i915_gpu_error.c+18 -120 replies
7/10drm/i915/bdw: collect semaphore error statedrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gpu_error.c drivers/gpu/drm/i915/intel_ringbuffer.h+55 -110 replies
8/10drm/i915: semaphore debugfsdrivers/gpu/drm/i915/i915_debugfs.c+70 -00 replies
9/10drm/i915/bdw: poll semaphoresdrivers/gpu/drm/i915/intel_ringbuffer.c+1 -00 replies
10/10DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphoresdrivers/gpu/drm/i915/i915_gem_context.c+7 -00 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/10R-b
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] Semaphores again. Needs shepherd.

The series is mostly done, but it needs a few last tweaks to make it acceptable for merge.

Chris noticed that the series doesn't properly work with the new VCS2 code that Daniel merged a couple of weeks ago. I too noticed this, but was remaining silent in the hopes that we could actually try to make progress. I raised concerns about this during the VCS2 merge on IRC. I only took a quick look, and it seems it's not too bad to implement, but it requires a bit of brain power to make sure it's correct.

The series is broken in another way because the new semaphore decoding which Daniel added. Ville posted a fix that looked sane to me, but I haven't a machine to test with. I'd recommend someone try to beat that into shape and test it. The series should be /okay/ without that though.

So here are the latest patches that I have. I just don't have enough time before my vacation to get these things done. They've gone through 5 rounds of rebase since the first series was posted on 12/13/13. They get the first thumbs up from Ville on Mar 5 (a couple of minor tweaks were required and could have been easily done by the maintainer). I've fixed everything I am aware. If someone could take over the patches, and get them merged, I think it'd really help in getting this useful feature added to our driver for gen8.

* The last two patches aren't needed, but are here for posterity.

If nobody has taken this over when I return I will see if I can complete it.

Ben Widawsky (10):
drm/i915: Make semaphore updates more precise drm/i915: gen specific ring init drm/i915/bdw: implement semaphore signal drm/i915/bdw: implement semaphore wait drm/i915: Implement MI decode for gen8 drm/i915: Extract semaphore error collection drm/i915/bdw: collect semaphore error state drm/i915: semaphore debugfs
drm/i915/bdw: poll semaphores
DONT_MERGE drm/i915: FORCE_RESTORE for gen8 semaphores

 drivers/gpu/drm/i915/i915_debugfs.c     |  70 +++++++
 drivers/gpu/drm/i915/i915_drv.h         |   2 +
 drivers/gpu/drm/i915/i915_gem_context.c |   7 +
 drivers/gpu/drm/i915/i915_gpu_error.c   |  79 ++++++--
 drivers/gpu/drm/i915/i915_irq.c         |  11 +-
 drivers/gpu/drm/i915/i915_reg.h         |   8 +-
 drivers/gpu/drm/i915/intel_ringbuffer.c | 342 +++++++++++++++++++++++---------
 drivers/gpu/drm/i915/intel_ringbuffer.h |  78 +++++++-
 8 files changed, 474 insertions(+), 123 deletions(-)
Signature · 1 line
1.9.2