Skip to content

qcow1: Input validation fixes

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesIn review
  2. v15 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Moved offset_l2_bits definition to patch 3 (Benoît)
- Added test cases for corner case values min-1 and max+1 (Benoît)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qcow1: Make padding in the header explicitblock/qcow.c+2 -13 replies
2/5qcow1: Check maximum cluster sizeblock/qcow.c tests/qemu-iotests/092 tests/qemu-iotests/092.out +1 more+85 -21 reply
3/5qcow1: Validate L2 table size (CVE-2014-0222)block/qcow.c tests/qemu-iotests/092 tests/qemu-iotests/092.out+34 -01 reply
4/5qcow1: Validate image size (CVE-2014-0223)block/qcow.c tests/qemu-iotests/092 tests/qemu-iotests/092.out+30 -23 replies
5/5qcow1: Stricter backing file length checkblock/qcow.c tests/qemu-iotests/092 tests/qemu-iotests/092.out+23 -20 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchBenoit Canet
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/5] qcow1: Input validation fixes

v2:
- Moved offset_l2_bits definition to patch 3 (Benoît)
- Added test cases for corner case values min-1 and max+1 (Benoît)

Kevin Wolf (5):
qcow1: Make padding in the header explicit
qcow1: Check maximum cluster size
qcow1: Validate L2 table size (CVE-2014-0222)
qcow1: Validate image size (CVE-2014-0223)
qcow1: Stricter backing file length check

 block/qcow.c               | 44 +++++++++++++++++----
 tests/qemu-iotests/092     | 98 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/092.out | 38 ++++++++++++++++++
 tests/qemu-iotests/group   |  1 +
 4 files changed, 174 insertions(+), 7 deletions(-)
 create mode 100755 tests/qemu-iotests/092
 create mode 100644 tests/qemu-iotests/092.out
Signature · 1 line
1.8.3.1