Skip to content

block: Purge qerror_report()

Markus Armbruster qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 5 repliesApplied
  2. v118 patches 28 repliesSuperseded

Changes in v2 from the cover letter

* Trivial rebase
* Fix error propagation in PATCH 04 [Eric]
* More tasteful line breaks in PATCH 04
* Indentation cleanup in PATCH 10 [Eric]
* Don't break sd_prealloc() in PATCH 14 [Eric]
* Fix error propagation in PATCH 17
* New PATCH 18 to fix silent failures

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/19blockdev: Don't use qerror_report_err() in drive_init()blockdev.c+2 -20 replies
2/19blockdev: Don't use qerror_report() in do_drive_del()blockdev.c+1 -20 replies
3/19qemu-nbd: Don't use qerror_report()qemu-nbd.c+3 -30 replies
4/19block/rbd: Propagate errors to open and create methodsblock/rbd.c+39 -321 reply
5/19block/ssh: Drop superfluous libssh2_session_last_errno() callsblock/ssh.c+4 -50 replies
6/19block/ssh: Propagate errors through check_host_key()block/ssh.c+49 -190 replies
7/19block/ssh: Propagate errors through authenticate()block/ssh.c+14 -90 replies
8/19block/ssh: Propagate errors through connect_to_ssh()block/ssh.c+17 -170 replies
9/19block/ssh: Propagate errors to open and create methodsblock/ssh.c+22 -250 replies
10/19block/vvfat: Propagate errors through enable_write_target()block/vvfat.c+7 -110 replies
11/19block/vvfat: Propagate errors through init_directories()block/vvfat.c+9 -70 replies
12/19block/sheepdog: Propagate errors through connect_to_sdog()block/sheepdog.c+55 -220 replies
13/19block/sheepdog: Propagate errors through get_sheep_fd()block/sheepdog.c+10 -80 replies
14/19block/sheepdog: Propagate errors through sd_prealloc()block/sheepdog.c+13 -71 reply
15/19block/sheepdog: Propagate errors through do_sd_create()block/sheepdog.c+21 -140 replies
16/19block/sheepdog: Propagate errors through find_vdi_name()block/sheepdog.c+11 -90 replies
17/19block/sheepdog: Propagate errors to open and create methodsblock/sheepdog.c+12 -281 reply
18/19block/sheepdog: Fix silent sd_open(), sd_create() failuresblock/sheepdog.c+5 -01 reply
19/19block/sheepdog: Don't use qerror_report()block/sheepdog.c+13 -130 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by.

PatchRichard W.M. JonesEric Blake
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report()

qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. This series purges it from the block subsystem.

It is based on Fam's "[PATCH v19 00/16] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD".

v2:
* Trivial rebase
* Fix error propagation in PATCH 04 [Eric]
* More tasteful line breaks in PATCH 04
* Indentation cleanup in PATCH 10 [Eric]
* Don't break sd_prealloc() in PATCH 14 [Eric]
* Fix error propagation in PATCH 17
* New PATCH 18 to fix silent failures

Markus Armbruster (19):
blockdev: Don't use qerror_report_err() in drive_init()
blockdev: Don't use qerror_report() in do_drive_del()
qemu-nbd: Don't use qerror_report()
block/rbd: Propagate errors to open and create methods block/ssh: Drop superfluous libssh2_session_last_errno() calls block/ssh: Propagate errors through check_host_key() block/ssh: Propagate errors through authenticate() block/ssh: Propagate errors through connect_to_ssh() block/ssh: Propagate errors to open and create methods block/vvfat: Propagate errors through enable_write_target() block/vvfat: Propagate errors through init_directories() block/sheepdog: Propagate errors through connect_to_sdog() block/sheepdog: Propagate errors through get_sheep_fd() block/sheepdog: Propagate errors through sd_prealloc() block/sheepdog: Propagate errors through do_sd_create() block/sheepdog: Propagate errors through find_vdi_name() block/sheepdog: Propagate errors to open and create methods block/sheepdog: Fix silent sd_open(), sd_create() failures block/sheepdog: Don't use qerror_report()

 block/rbd.c      |  71 ++++++++++++++------------
 block/sheepdog.c | 149 ++++++++++++++++++++++++++++++++++--------------------
 block/ssh.c      | 151 +++++++++++++++++++++++++++++++++----------------------
 block/vvfat.c    |  34 ++++++-------
 blockdev.c       |   7 ++-
 qemu-nbd.c       |   6 +--
 6 files changed, 246 insertions(+), 172 deletions(-)
Signature · 1 line
1.8.1.4