bonding: simple macro cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 1 replyIn review
- v29 patches 6 repliesSuperseded
- v15 patches 9 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | bonding: remove BOND_MODE_IS_LB macrodrivers/ | +2 | 0 replies | |
| 2/9 | bonding: make TX_QUEUE_OVERRIDE() macro an inline functiondrivers/ drivers/ | +9 | 0 replies | |
| 3/9 | bonding: make BOND_NO_USES_ARP an inline functiondrivers/ drivers/ drivers/ | +8 | 0 replies | |
| 4/9 | bonding: make USES_PRIMARY inline functionsdrivers/ drivers/ drivers/ +1 more | +32 | 0 replies | |
| 5/9 | bonding: create a macro for bond mode and use itdrivers/ drivers/ drivers/ +5 more | +60 | 0 replies | |
| 6/9 | bonding: make IS_IP_TARGET_UNUSABLE_ADDRESS an inline functiondrivers/ drivers/ drivers/ | +8 | 0 replies | |
| 7/9 | bonding: convert IS_UP(slave->dev) to inline functiondrivers/ drivers/ drivers/ +1 more | +16 | 0 replies | |
| 8/9 | bonding: rename {,bond_}slave_can_tx and clean it updrivers/ drivers/ | +10 | 0 replies | |
| 9/9 | bonding: replace SLAVE_IS_OK() with bond_slave_can_tx()drivers/ drivers/ drivers/ +1 more | +11 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 net-next 0/9] bonding: simple macro cleanup
Hi,
Trivial patchset that converts most of the bonding's macros into inline functions. It introduces only one macro, BOND_MODE(), which is just bond->params.mode, better to write/understand/remember.
The only real change is the removal of IFF_UP verification, which always came in pair with && netif_running(), and is though useless, as it's always IFF_UP when LINK_STATE_RUNNING.
v2->v3: fix 3/9 to actually invert bond_mode_uses_arp() and add
bond_uses_arp() alongside bond_mode_uses_arp()v1->v2: use inlined functions instead of macros.
CC Jay Vosburgh <[email protected]>
CC Andy Gospodarek <[email protected]>
Signed-off-by Veaceslav Falico <[email protected]>
--- drivers/net/bonding/bond_3ad.c | 6 +- drivers/net/bonding/bond_alb.c | 18 ++--- drivers/net/bonding/bond_debugfs.c | 2 +- drivers/net/bonding/bond_main.c | 143 ++++++++++++++++----------------- drivers/net/bonding/bond_netlink.c | 6 +- drivers/net/bonding/bond_options.c | 10 +-- drivers/net/bonding/bond_procfs.c | 14 ++-- drivers/net/bonding/bond_sysfs.c | 14 ++-- drivers/net/bonding/bond_sysfs_slave.c | 2 +- drivers/net/bonding/bonding.h | 89 ++++++++++---------- 10 files changed, 150 insertions(+), 154 deletions(-)