Skip to content

bonding: remove rlb_enabled and alb_set_mac_address()

Veaceslav Falico netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bonding: remove rlb_enabled and use mode == ALB insteaddrivers/net/bonding/bond_alb.c drivers/net/bonding/bond_alb.h drivers/net/bonding/bond_main.c+17 -240 replies
2/2bonding: remove alb_set_mac_address()drivers/net/bonding/bond_alb.c+0 -616 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac_address()

Hi,

Currently rlb_enabled works as
rlb_enabled == (BOND_MODE(bond) == BOND_MODE_ALB)
so we can always use this verification and drop maintenance of this variable.

alb_set_mac_address(), OTOH, isn't used at all (as the mac changing logic is used in other parts), and isn't ever called, so it's safe to remove it as well.

CC Jay Vosburgh <[email protected]>
CC Andy Gospodarek <[email protected]>
CC [email protected]
Signed-off-by Veaceslav Falico <[email protected]>
---
 drivers/net/bonding/bond_alb.c  | 95 ++++++-----------------------------------
 drivers/net/bonding/bond_alb.h  |  3 +-
 drivers/net/bonding/bond_main.c |  2 +-
 3 files changed, 16 insertions(+), 84 deletions(-)

Read the cover letter in its thread