Skip to content

xfs: introduce struct xfs_da_geometry

Dave Chinner linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 7 repliesIn review
  2. v216 patches 27 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16xfs: introduce directory geometry structurefs/xfs/xfs_attr.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_attr_list.c +5 more+97 -211 reply
2/16xfs: move directory block translatiosn to xfs_dir2_priv.hfs/xfs/xfs_da_format.c fs/xfs/xfs_da_format.h fs/xfs/xfs_dir2_priv.h+139 -1380 replies
3/16xfs: kill XFS_DIR2...FIRSTDB macrosfs/xfs/xfs_da_format.c fs/xfs/xfs_da_format.h fs/xfs/xfs_dir2.c +2 more+17 -170 replies
4/16xfs: convert dir byte/off conversion to xfs_da_geometryfs/xfs/xfs_dir2.c fs/xfs/xfs_dir2_priv.h fs/xfs/xfs_dir2_readdir.c+14 -130 replies
5/16xfs: convert directory dablk conversion to xfs_da_geometryfs/xfs/xfs_dir2.c fs/xfs/xfs_dir2_data.c fs/xfs/xfs_dir2_leaf.c +3 more+48 -430 replies
6/16xfs: convert directory db conversion to xfs_da_geometryfs/xfs/xfs_da_format.c fs/xfs/xfs_dir2.c fs/xfs/xfs_dir2_block.c +6 more+93 -700 replies
7/16xfs: convert directory segment limits to xfs_da_geometryfs/xfs/xfs_da_btree.c fs/xfs/xfs_dir2.c fs/xfs/xfs_dir2_block.c +5 more+37 -420 replies
8/16xfs: convert m_dirblkfsbs to xfs_da_geometryfs/xfs/xfs_bmap.c fs/xfs/xfs_da_btree.c fs/xfs/xfs_dir2.c +6 more+27 -330 replies
9/16xfs: convert m_dirblksize to xfs_da_geometryfs/xfs/xfs_da_btree.c fs/xfs/xfs_da_format.c fs/xfs/xfs_dir2.c +11 more+115 -1060 replies
10/16xfs: convert dir/attr btree threshold to xfs_da_geometryfs/xfs/xfs_attr_leaf.c fs/xfs/xfs_dir2.c fs/xfs/xfs_dir2_node.c +1 more+2 -60 replies
11/16xfs: move node entry counts to xfs_da_geometryfs/xfs/xfs_attr.c fs/xfs/xfs_da_btree.c fs/xfs/xfs_dir2.c +2 more+11 -160 replies
12/16xfs: reduce direct usage of mp->m_dir_geofs/xfs/xfs_dir2.c fs/xfs/xfs_dir2.h fs/xfs/xfs_dir2_readdir.c+65 -741 reply
13/16xfs: remove mp->m_dir_geo from directory loggingfs/xfs/xfs_dir2.h fs/xfs/xfs_dir2_block.c fs/xfs/xfs_dir2_data.c +3 more+137 -1480 replies
14/16xfs: use xfs_da_geometry for block size in attr codefs/xfs/xfs_attr.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_log_rlimit.c+10 -100 replies
15/16xfs: pass xfs_da_args to xfs_attr_leaf_newentsizefs/xfs/xfs_attr.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_attr_leaf.h+19 -350 replies
16/16xfs: repalce attr LBSIZE with xfs_da_geometryfs/xfs/xfs_attr.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_attr_remote.c +1 more+89 -920 replies

Reviews trailers per patch

14 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBrian FosterChristoph Hellwig
SeriesR-b
1/16R-b
2/16
3/16R-b R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH 00/16 V3] xfs: introduce struct xfs_da_geometry

Hi folks,

Version three of the patchset first posted here:

http://oss.sgi.com/pipermail/xfs/2014-May/036125.html

This version addresses the review comments so far.

Changelog:

Version 3:
- added xfs_da_unmount
- moved dir2 conversion functions to xfs_dir2_priv.h
- converted xfs_dir2_readdir.c to use local geo variables
- added a patch to remove newly redundant geometry fields from the struct xfs_da_state

Version 2:
- patch removing checks from xfs_da_read_buf() sent separately
- dropped patch adding xfs_da_geometry to the inode forks as it's not currently needed
- cleared up all the "XXX" notations added in the RFC series
- fixed several bugs in different patches as a result of incorrect conversions
- ensured each patch compiled and passes xfstests individually

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs