Skip to content

perf tools: Factor sort elide

Jiri Olsa lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf tools: Remove elide setup for SORT_MODE__MEMORY modetools/perf/util/sort.c+0 -130 replies
2/2perf tools: Move elide bool into perf_hpp_fmt structtools/perf/ui/browsers/hists.c tools/perf/util/hist.h tools/perf/util/sort.c +1 more+67 -400 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamhyung Kim
SeriesA-b A-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC/PATCH 0/2] perf tools: Factor sort elide

hi,
factoring the elide code to make perf_hpp__should_skip function cheap call/check again.

Also I was wondering.. do we want to get rid of sort_entry structs in favor of perf_hpp__* stuff? Any plans?

I'm sending this a RFC, since any other such refactoring would change this stuff for sure as well ;-).

thanks,
jirka

Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Corey Ashford <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/ui/browsers/hists.c |   8 ++++----
 tools/perf/util/hist.h         |   8 +++++++-
 tools/perf/util/sort.c         | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------
 tools/perf/util/sort.h         |   2 +-
 4 files changed, 67 insertions(+), 53 deletions(-)