Skip to content

mainly d_splice_alias fixes

J. Bruce Fields linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11namei: trivial fix to vfs_rename_dir commentfs/namei.c+1 -10 replies
2/11dcache: move d_splice_aliasfs/dcache.c+52 -520 replies
3/11dcache: close d_move race in d_splice_aliasfs/dcache.c+6 -10 replies
4/11dcache: d_splice_alias mustn't create directory aliasesfs/dcache.c+9 -20 replies
5/11dcache: d_splice_alias should ignore DCACHE_DISCONNECTEDfs/dcache.c+4 -40 replies
6/11dcache: d_obtain_alias callers don't all want DISCONNECTEDfs/btrfs/super.c fs/ceph/super.c fs/dcache.c +3 more+54 -310 replies
7/11dcache: remove unused d_find_alias parameterfs/dcache.c+5 -80 replies
8/11dcache: d_find_alias needn't recheck IS_ROOT && DCACHE_DISCONNECTEDfs/dcache.c+3 -60 replies
9/11exportfs: update Exporting documentationDocumentation/filesystems/nfs/Exporting+23 -154 replies
10/11dcache: d_materialise_unique isn't GPL-onlyfs/dcache.c+1 -10 replies
11/11dcache: d_splice_alias should detect loopsfs/dcache.c+5 -00 replies

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/11
2/11R-b
3/11R-b
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] mainly d_splice_alias fixes

From: "J. Bruce Fields" <[email protected]>

The following are fixes mainly to d_splice_alias and related code. I think they'd be appropriate for 3.16, though some of them could probably use another pair of eyes.

For future work:

- d_splice_alias and d_materialise_unique are now doing nearly the same thing and should probably be combined.
- __d_unalias's dependence on trylock's can cause spurious lookup failures on NFS. I've been meaning to look into whether it's reasonable (and good enough) to just retry in those cases.

--b.

J. Bruce Fields (11):
namei: trivial fix to vfs_rename_dir comment
dcache: move d_splice_alias
dcache: close d_move race in d_splice_alias
dcache: d_splice_alias mustn't create directory aliases
dcache: d_splice_alias should ignore DCACHE_DISCONNECTED
dcache: d_obtain_alias callers don't all want DISCONNECTED
dcache: remove unused d_find_alias parameter
dcache: d_find_alias needn't recheck IS_ROOT && DCACHE_DISCONNECTED
exportfs: update Exporting documentation
dcache: d_materialise_unique isn't GPL-only
dcache: d_splice_alias should detect loops

 Documentation/filesystems/nfs/Exporting |   38 +++---
 fs/btrfs/super.c                        |    9 +-
 fs/ceph/super.c                         |    2 +-
 fs/dcache.c                             |  198 +++++++++++++++++++------------
 fs/namei.c                              |    2 +-
 fs/nfs/getroot.c                        |    2 +-
 fs/nilfs2/super.c                       |    2 +-
 include/linux/dcache.h                  |    1 +
 8 files changed, 148 insertions(+), 106 deletions(-)
Signature · 1 line
1.7.9.5