Skip to content

RFC Add support for showing headers in the hist browser.

Arnaldo Carvalho de Melo lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf ui browser: Add ->rows to disambiguate from ->heighttools/perf/ui/browser.c tools/perf/ui/browser.h tools/perf/ui/browsers/hists.c+24 -240 replies
2/7perf ui browser: Allow overriding refresh_dimensions methodtools/perf/ui/browser.c tools/perf/ui/browser.h+6 -20 replies
3/7perf hists browser: Introduce gotorc methodtools/perf/ui/browsers/hists.c+8 -30 replies
4/7perf hists browser: Override ui_browser refresh_dimensions methodtools/perf/ui/browsers/hists.c+13 -50 replies
5/7perf hists browser: Add support for showing columns headertools/perf/ui/browsers/hists.c+40 -20 replies
6/7perf hists browser: Display columns header text on 'H' presstools/perf/ui/browsers/hists.c+45 -20 replies
7/7perf hists browser: Add ui.show-headers config file optiontools/perf/ui/browsers/hists.c tools/perf/util/config.c tools/perf/util/symbol.c +1 more+17 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCHES 0/7] Add support for showing headers in the hist browser.

Hi Jiri,

As you guys know this allows showing the columns headers on the hists
browsers, used in 'perf top' and 'perf report'. So, to test it, just apply, fire one of those tools and press 'H' repeatedly.

Please take a look, this should be mostly equivalent to your patchkit in
intent, but fixes some problems and is more consistent with how I first designed the ui_browser code.

Please let me know if you are ok with it and if I can have your
Acked-by and perhaps Tested-by tags for the code I wrote.

Namhyung, since you reviewed the previous patchkit, I'd like to know
if I can keep the acked-by and perhaps a tested-by too. This should address the problems that Jiri pointed out in our private conversation.

Thanks,

- Arnaldo

Arnaldo Carvalho de Melo (5):
perf ui browser: Add ->rows to disambiguate from ->height perf ui browser: Allow overriding refresh_dimensions method perf hists browser: Introduce gotorc method
perf hists browser: Override ui_browser refresh_dimensions method perf hists browser: Add support for showing columns header

Jiri Olsa (2):
perf hists browser: Display columns header text on 'H' press perf hists browser: Add ui.show-headers config file option

 tools/perf/ui/browser.c        |  37 ++++++------
 tools/perf/ui/browser.h        |   3 +-
 tools/perf/ui/browsers/hists.c | 128 +++++++++++++++++++++++++++++++++++------
 tools/perf/util/config.c       |  13 +++++
 tools/perf/util/symbol.c       |   1 +
 tools/perf/util/symbol.h       |   3 +-
 6 files changed, 149 insertions(+), 36 deletions(-)
Signature · 1 line
1.9.3