nfs_page_group_lock cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | nfs: change nfs_page_group_lock argumentfs/ fs/ | +8 | 0 replies | |
| 2/5 | nfs: fix nonblocking calls to nfs_page_group_lockfs/ | +14 | 0 replies | |
| 3/5 | nfs: use blocking page_group_lock in add_requestfs/ | +2 | 0 replies | |
| 4/5 | nfs: fix error handling in lock_and_join_requestsfs/ | +4 | 0 replies | |
| 5/5 | nfs: don't sleep with inode lock in lock_and_join_requestsfs/ fs/ include/ | +30 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Peng Tao |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] nfs_page_group_lock cleanup
These patches clean up some issues surrouding nfs_page_group_lock:
- normalize wait/nonblock argument
- make nonblocking calls really nonblocking
- handle errors
- ensure that we don't call blocking nfs_page_group_lock when holding the inode spinlock
This cleanup was inspired by Fengguang Wu's report that we were sleeping with locks held in nfs_lock_and_join_requests.
Weston Andros Adamson (5):
nfs: change nfs_page_group_lock argument
nfs: fix nonblocking calls to nfs_page_group_lock
nfs: use blocking page_group_lock in add_request
nfs: fix error handling in lock_and_join_requests
nfs: don't sleep with inode lock in lock_and_join_requests
fs/nfs/pagelist.c | 59 ++++++++++++++++++++++++++++++------------------ fs/nfs/write.c | 21 +++++++++++++---- include/linux/nfs_page.h | 1 + 3 files changed, 55 insertions(+), 26 deletions(-)
Signature · 1 line
1.8.5.2 (Apple Git-48)