Skip to content

nfs_page_group_lock cleanup

Weston Andros Adamson linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nfs: change nfs_page_group_lock argumentfs/nfs/pagelist.c fs/nfs/write.c+8 -70 replies
2/5nfs: fix nonblocking calls to nfs_page_group_lockfs/nfs/pagelist.c+14 -90 replies
3/5nfs: use blocking page_group_lock in add_requestfs/nfs/pagelist.c+2 -110 replies
4/5nfs: fix error handling in lock_and_join_requestsfs/nfs/write.c+4 -10 replies
5/5nfs: don't sleep with inode lock in lock_and_join_requestsfs/nfs/pagelist.c fs/nfs/write.c include/linux/nfs_page.h+30 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPeng Tao
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] nfs_page_group_lock cleanup

These patches clean up some issues surrouding nfs_page_group_lock:

- normalize wait/nonblock argument
- make nonblocking calls really nonblocking
- handle errors
- ensure that we don't call blocking nfs_page_group_lock when holding the inode spinlock

This cleanup was inspired by Fengguang Wu's report that we were sleeping with locks held in nfs_lock_and_join_requests.

Weston Andros Adamson (5):
nfs: change nfs_page_group_lock argument
nfs: fix nonblocking calls to nfs_page_group_lock
nfs: use blocking page_group_lock in add_request
nfs: fix error handling in lock_and_join_requests
nfs: don't sleep with inode lock in lock_and_join_requests

 fs/nfs/pagelist.c        | 59 ++++++++++++++++++++++++++++++------------------
 fs/nfs/write.c           | 21 +++++++++++++----
 include/linux/nfs_page.h |  1 +
 3 files changed, 55 insertions(+), 26 deletions(-)
Signature · 1 line
1.8.5.2 (Apple Git-48)