RFC: Fix nfs_generic_pgio page vector issues
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nfs: disallow duplicate pages in pgio page vectorsfs/ | +19 | 0 replies | |
| 2/2 | nfs: can_coalesce_requests must enforce contiguityfs/ | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] RFC: Fix nfs_generic_pgio page vector issues
This patchset fixes a few issues with the creation of nfs_pageio_descriptor page vectors, which are passed to nfs_pgio_header structures.
These were first found by Toralf Förster <[email protected]> by running trinity, but I've since received a report of a real world usecase that hit a related issue: kvm with cache=none.
There are two problems that are closely related and seem to only be triggered by direct i/o writev()/readv() calls.
The fixes are:
- do not coalesce pages unless they are contiguous in file position *and* within / betwen pages.
- do not allow duplicated pages in the pagevector
I'm still testing these, but I thought I'd share what I have with the list.
-dros
Weston Andros Adamson (2):
nfs: disallow duplicate pages in pgio page vectors
nfs: can_coalesce_requests must enforce contiguity
fs/nfs/pagelist.c | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.5.2 (Apple Git-48)