Skip to content

xfs: clean up xlog_recover_process_data

Dave Chinner linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 6 repliesIn review
  2. v1 RFC4 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xfs: refactor xlog_recover_process_data()fs/xfs/xfs_log_recover.c+127 -732 replies
2/5xfs: recovery of XLOG_UNMOUNT_TRANS leaks memoryfs/xfs/xfs_log_recover.c+15 -122 replies
3/5xfs: fix double free in xlog_recover_commit_transfs/xfs/xfs_log_recover.c+6 -20 replies
4/5xfs: reorganise transaction recovery item codefs/xfs/xfs_log_recover.c+179 -1791 reply
5/5xfs: refactor recovery transaction start handlingfs/xfs/xfs_log_recover.c+34 -431 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/5R-b
2/5R-b
3/5
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/5 v2] xfs: clean up xlog_recover_process_data

Hi folks,

This is a new version of the log recovery transaction processing cleanup I first posted here:

http://oss.sgi.com/archives/xfs/2014-08/msg00367.html

It's largely the same, but there's been a couple of but fixes and rework done to it.

Version 2
- use sizeof(variable) consistently
- reworked transaction lookup factoring to encapsulate start ophdr processing completely.
- re-ordered checks for opheader length validity to so we do all the ophdr validity checks before we try to process it.
- added patch to re-integrate simple use-once functions to look up and allocate recovery transaction structures.

-Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs