Skip to content

scsi logging update (the boring part)

Hannes Reinecke linux-scsi 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest27 patches 11 repliesIn review
  2. v7 posting 2/227 patches 5 repliesSuperseded
  3. v7 posting 1/226 patches 3 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v626 patches2 repliesSuperseded
v524 patches23 repliesSuperseded
v423 patches14 repliesSuperseded
v338 patches13 repliesApplied
v220 patches28 repliesSuperseded
v122 patches40 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27Remove scsi_cmd_print_sense_hdr()drivers/scsi/constants.c include/scsi/scsi_dbg.h+0 -160 replies
2/27sd: Remove scsi_print_sense() in sd_done()drivers/scsi/sd.c+0 -10 replies
3/27aha152x: Debug output update and whitespace cleanupdrivers/scsi/aha152x.c+224 -7700 replies
4/27scsi: introduce sdev_prefix_printk()drivers/scsi/ch.c drivers/scsi/sd.h drivers/scsi/sg.c +3 more+17 -110 replies
5/27scsi: Use sdev as argument for sense code printingdrivers/scsi/53c700.c drivers/scsi/ch.c drivers/scsi/constants.c +13 more+99 -890 replies
6/27acornscsi: use scsi_print_command()drivers/scsi/arm/acornscsi.c+6 -60 replies
7/27fas216: Return DID_ERROR for incomplete data transferdrivers/scsi/arm/fas216.c+1 -20 replies
8/27fas216: Update logging messagesdrivers/scsi/arm/fas216.c+11 -150 replies
9/2753c700: remove scsi_print_sense() usagedrivers/scsi/53c700.c+2 -70 replies
10/27scsi: stop decoding if scsi_normalize_sense() failsdrivers/scsi/constants.c+16 -180 replies
11/27scsi: do not decode sense extrasdrivers/scsi/constants.c+0 -620 replies
12/27scsi: use 'bool' as return value for scsi_normalize_sense()drivers/scsi/scsi_error.c drivers/scsi/scsi_lib.c include/scsi/scsi_eh.h+16 -160 replies
13/27scsi: remove scsi_print_status()drivers/scsi/constants.c include/scsi/scsi_dbg.h+0 -360 replies
14/27Implement scsi_opcode_sa_namedrivers/scsi/constants.c+53 -780 replies
15/27scsi: merge print_opcode_name()drivers/scsi/constants.c+33 -550 replies
16/27scsi: consolidate opcode lookup in scsi_opcode_sa_name()drivers/scsi/constants.c+22 -150 replies
17/27scsi: repurpose the last argument from print_opcode_name()drivers/scsi/arm/fas216.c drivers/scsi/ch.c drivers/scsi/constants.c +2 more+27 -300 replies
18/27scsi: Remove scsi_print_command when calling abortdrivers/scsi/53c700.c drivers/scsi/NCR5380.c drivers/scsi/arm/fas216.c +4 more+11 -270 replies
19/27scsi: separate out scsi_(host|driver)byte_string()drivers/scsi/constants.c include/scsi/scsi_dbg.h+46 -140 replies
20/27Remove scsi_show_result()drivers/scsi/constants.c drivers/scsi/sd.c drivers/scsi/ufs/ufshcd.c +1 more+28 -430 replies
21/27scsi: simplify scsi_log_(send|completion)drivers/scsi/constants.c drivers/scsi/scsi.c drivers/scsi/scsi_lib.c +1 more+56 -440 replies
22/27scsi: fixup logging messages in scsi_error.cdrivers/scsi/hosts.c drivers/scsi/scsi_error.c+39 -420 replies
23/27scsi: use shost argument in scsi_eh_prt_fail_statsdrivers/scsi/scsi_error.c+1 -10 replies
24/27scsi_error: document scsi_try_to_abort_cmddrivers/scsi/scsi_error.c+21 -30 replies
25/27scsi: check for correct return code in scsi_eh_abort_cmds()drivers/scsi/scsi_error.c+1 -12 replies
26/27scsi: correct return values for .eh_abort_handler implementationsdrivers/scsi/NCR5380.c drivers/scsi/aha1740.c drivers/scsi/esas2r/esas2r_main.c +1 more+7 -72 replies
27/27scsi: ratelimit I/O error messagesdrivers/scsi/scsi_lib.c+20 -125 replies

Reviews trailers per patch

26 of 27 patches have a Reviewed-by or Acked-by.

PatchRobert ElliottChristoph HellwigYoshihiro Yunomae
1/27R-b R-b
2/27R-b R-b
3/27R-b R-b
4/27R-b R-b
5/27R-b R-b
6/27R-b R-b
7/27R-b R-b
8/27R-b R-b
9/27R-b R-b
10/27R-b R-b
11/27R-b R-b
12/27R-b R-b R-b
13/27R-b R-b
14/27R-b R-b
15/27R-b R-b
16/27R-b
17/27R-b R-b
18/27R-b R-b
19/27R-b R-b
20/27R-b R-b
21/27R-b R-b
22/27R-b R-b
23/27R-b R-b
24/27R-b R-b
25/27
26/27R-b R-b
27/27T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCHv8 00/27] scsi logging update (the boring part)

here is now the eigth iteration of my scsi logging update. With this I've updated the patch to ratelimit I/O error messages as suggested by Robert Elliott.
Additionally I've updated it to core-for-3.19 and included the missing hunks for ufs as requested by Christoph Hellwig.

Hannes Reinecke (27):
Remove scsi_cmd_print_sense_hdr()
sd: Remove scsi_print_sense() in sd_done()
aha152x: Debug output update and whitespace cleanup
scsi: introduce sdev_prefix_printk()
scsi: Use sdev as argument for sense code printing
acornscsi: use scsi_print_command()
fas216: Return DID_ERROR for incomplete data transfer
fas216: Update logging messages
53c700: remove scsi_print_sense() usage
scsi: stop decoding if scsi_normalize_sense() fails
scsi: do not decode sense extras
scsi: use 'bool' as return value for scsi_normalize_sense()
scsi: remove scsi_print_status()
Implement scsi_opcode_sa_name
scsi: merge print_opcode_name()
scsi: consolidate opcode lookup in scsi_opcode_sa_name()
scsi: repurpose the last argument from print_opcode_name()
scsi: Remove scsi_print_command when calling abort
scsi: separate out scsi_(host|driver)byte_string() Remove scsi_show_result()
scsi: simplify scsi_log_(send|completion)
scsi: fixup logging messages in scsi_error.c
scsi: use shost argument in scsi_eh_prt_fail_stats
scsi_error: document scsi_try_to_abort_cmd
scsi: check for correct return code in scsi_eh_abort_cmds()
scsi: correct return values for .eh_abort_handler implementations
scsi: ratelimit I/O error messages

 drivers/scsi/53c700.c             |  13 +-
 drivers/scsi/NCR5380.c            |   7 +-
 drivers/scsi/aha152x.c            | 994 +++++++++-----------------------------
 drivers/scsi/aha1740.c            |   2 +-
 drivers/scsi/arm/acornscsi.c      |  12 +-
 drivers/scsi/arm/fas216.c         |  39 +-
 drivers/scsi/atari_NCR5380.c      |   3 +-
 drivers/scsi/ch.c                 |  29 +-
 drivers/scsi/constants.c          | 578 +++++++++-------------
 drivers/scsi/esas2r/esas2r_main.c |   2 +-
 drivers/scsi/hosts.c              |   4 +-
 drivers/scsi/megaraid.c           |   8 +-
 drivers/scsi/osst.c               |   8 +-
 drivers/scsi/ps3rom.c             |   4 -
 drivers/scsi/scsi.c               |  45 +-
 drivers/scsi/scsi_error.c         | 123 ++---
 drivers/scsi/scsi_ioctl.c         |   2 +-
 drivers/scsi/scsi_lib.c           |  29 +-
 drivers/scsi/sd.c                 |  60 +--
 drivers/scsi/sd.h                 |   6 +-
 drivers/scsi/sg.c                 |   6 +-
 drivers/scsi/sr.h                 |   3 +-
 drivers/scsi/sr_ioctl.c           |  10 +-
 drivers/scsi/st.c                 |   9 +-
 drivers/scsi/stex.c               |   9 +-
 drivers/scsi/storvsc_drv.c        |   3 +-
 drivers/scsi/sun3_NCR5380.c       |   3 +-
 drivers/scsi/ufs/ufshcd.c         |   8 +-
 include/scsi/scsi_dbg.h           |  28 +-
 include/scsi/scsi_device.h        |   9 +
 include/scsi/scsi_eh.h            |  14 +-
 31 files changed, 703 insertions(+), 1367 deletions(-)
Signature · 1 line
1.8.5.2