Skip to content

e1000: convert to build_skb/napi_gro_frags api

Florian Westphal netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 1 replyIn review
  2. v17 patches 1 replySuperseded

Changes in v2 from the cover letter

- in last patch, remove unneeded parens and casts, pointed out by Sergei Shtylyov.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7e1000: move e1000_tbi_adjust_stats to where its useddrivers/net/ethernet/intel/e1000/e1000_hw.c drivers/net/ethernet/intel/e1000/e1000_hw.h drivers/net/ethernet/intel/e1000/e1000_main.c+77 -800 replies
2/7e1000: move tbi workaround code into helper functiondrivers/net/ethernet/intel/e1000/e1000_main.c+33 -300 replies
3/7e1000: perform copybreak ahead of dma unmapdrivers/net/ethernet/intel/e1000/e1000_main.c+43 -300 replies
4/7e1000: add and use e1000_rx_buffer info for rxdrivers/net/ethernet/intel/e1000/e1000.h drivers/net/ethernet/intel/e1000/e1000_ethtool.c drivers/net/ethernet/intel/e1000/e1000_main.c+27 -230 replies
5/7e1000: rename struct e1000_buffer to e1000_tx_bufferdrivers/net/ethernet/intel/e1000/e1000.h drivers/net/ethernet/intel/e1000/e1000_ethtool.c drivers/net/ethernet/intel/e1000/e1000_main.c+17 -170 replies
6/7e1000: convert to build_skbdrivers/net/ethernet/intel/e1000/e1000.h drivers/net/ethernet/intel/e1000/e1000_ethtool.c drivers/net/ethernet/intel/e1000/e1000_main.c+131 -1200 replies
7/7e1000: switch to napi_gro_frags apidrivers/net/ethernet/intel/e1000/e1000_main.c+32 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/7] e1000: convert to build_skb/napi_gro_frags api

Changes since v1:
- in last patch, remove unneeded parens and casts, pointed out by Sergei Shtylyov.

v1 cover letter:

e1000 driver preallocates skbs, then sends them up the stack.

This patch series changes the rx routine to only preallocate packet buffers, then allocate the skb right before sending the packet up the stack.

This gives slight performance inprovements as the skb will be fresh in the cache once its allocated/initialized.

The default-mtu 1500 path is converted to
build_skb()/netdev_alloc_frag.

Jumbo path is converted to napi_gro_frags.

Note that this has only been tested with
kvms e1000 emulation.