qemu:pci-assign: try to pci-assign.c
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest1 patch 5 repliesIn review
- v11 patch 4 repliesSuperseded
Changes in v3 from the cover letter
* Don't move out those common structures.
* Just include minimum required head file.
* Rename dev_load_option_rom with pci_assign_dev_load_option_rom to avoid global namespace pollution.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | hw/pci-assign: split pci-assign.chw/ include/ | +46 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [Qemu-devel] [v3][PATCH 0/1] qemu:pci-assign: try to pci-assign.c
v3:
* Don't move out those common structures.
* Just include minimum required head file.
* Rename dev_load_option_rom with pci_assign_dev_load_option_rom to avoid global namespace pollution.
v2:
* v1 is making so much code inline, so try to move it to an out of line file.
* rename pci-assign not pci_assign.
A you know I'm working on supporting IGD passthrough.
Here we need load VGABIOS to work out IGD case. Obviously something may be duplicated to kvm codes, we should unify some codes but looks its not easy to finish that in short time. So as Michael suggestion, at least we'd better split assigned_dev_load_option_rom to reuse on both kvm and xen.
I don't finish all IGD stuff patches but here I'd like to post some related codes to show how to use assigned_dev_load_option_rom() lately.
+static int get_vgabios(XenPCIPassthroughState *s, void *ptr,
+ XenHostPCIDevice *dev)
+{
+ int size = 0;
+
+ size = dev_load_option_rom(&s->dev, OBJECT(dev), ptr, dev->domain,
+ dev->bus, dev->dev, dev->func);
+
+ return size;
+}
+
+int xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev) +{
+ void *bios = NULL; + int bios_size = 0; + int rc = 0;
+
+ if (!is_vga_passthrough(dev)) {
+ return rc;
+ }
+
+ bios_size = get_vgabios(s, bios, dev);
+ if (!bios || !bios_size) {
+ XEN_PT_ERR(NULL, "VGA: getting VBIOS!\n"); + rc = -1; + goto out;
+ }
...
----------------------------------------------------------------
Tiejun Chen (1):
hw/pci-assign: split pci-assign.c
hw/i386/kvm/pci-assign.c | 46 ++++++++++++++++++++++++++++++---------------- include/hw/pci/pci-assign.h | 16 ++++++++++++++++ 2 files changed, 46 insertions(+), 16 deletions(-) create mode 100644 include/hw/pci/pci-assign.h
Thanks
Tiejun