Skip to content

Mbuf Structure Rework, part 2

Bruce Richardson dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 3 repliesIn review
  2. v113 patches 31 repliesSuperseded

Changes in v2 from the cover letter

* General minor updates follow comments on V1 set
* Updated a number of patches to include KNI mbuf changes where needed
* Deferred the patch to add the packet type field to a future patch set
* After removing meta-data element from mbuf structure also added in patch to move the macros to rte_port/rte_port.h

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13mbuf: replace data pointer by an offsetapp/test-pmd/csumonly.c app/test-pmd/flowgen.c app/test-pmd/icmpecho.c +32 more+146 -1440 replies
2/13mbuf: reorder fields by time of uselib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h lib/librte_mbuf/rte_mbuf.h+21 -162 replies
3/13mbuf: expand ol_flags field to 64-bitsapp/test-pmd/config.c app/test-pmd/csumonly.c app/test-pmd/rxonly.c +10 more+106 -1180 replies
4/13mbuf: introduce a flag to indicate a control mbuflib/librte_mbuf/rte_mbuf.c lib/librte_mbuf/rte_mbuf.h+21 -00 replies
5/13mbuf: minor changes for readabilitylib/librte_mbuf/rte_mbuf.h+16 -170 replies
6/13mbuf: use macros only to access the mbuf metadatalib/librte_mbuf/rte_mbuf.h+8 -140 replies
7/13mbuf: move metadata macros to rte_port librarylib/librte_mbuf/rte_mbuf.h lib/librte_port/rte_port.h+22 -180 replies
8/13mbuf: add named points inside the mbuf structurelib/librte_mbuf/rte_mbuf.h+9 -00 replies
9/13ixgbe: rework vector pmd following mbuf changesconfig/common_linuxapp lib/librte_pmd_ixgbe/ixgbe_rxtx.c lib/librte_pmd_ixgbe/ixgbe_rxtx.h +1 more+53 -900 replies
10/13mbuf: split mbuf across two cache lines.app/test/test_mbuf.c lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h lib/librte_mbuf/rte_mbuf.h+6 -50 replies
11/13mbuf: move l2_len and l3_len to second cache linelib/librte_mbuf/rte_mbuf.h+9 -70 replies
12/13ixgbe: Fix perf regression due to moved pool ptrlib/librte_pmd_ixgbe/ixgbe_rxtx.c lib/librte_pmd_ixgbe/ixgbe_rxtx.h lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c+38 -761 reply
13/13ixgbe: Improve slow-path perf: vector scattered RXlib/librte_pmd_ixgbe/ixgbe_rxtx.c lib/librte_pmd_ixgbe/ixgbe_rxtx.h lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c+186 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/13] Mbuf Structure Rework, part 2

This patch set continues on from the changes in part 1, and depends upon that patch set.

This patch set reorders the fields in the mbuf structure and splits the structure across two cache lines, given lots of new space for new fields to be added. This set uses some of that space by expanding the ol_flags field. A part 3 patchset is planned to introduce some other new fields into the new mbuf structure.

With the splitting of the mbuf across multiple cache lines, performance degradations are seen inside the drivers, both fast-path and slow path. For the fast-path, this patchset reworks the way in which the pool pointer is used to free packets post-TX, which removes the perf regression. For the slow path, an alternative approach is taken - a new scattered packets RX function is introduced into the vector PMD. Using this function, throughput for the slow path RX-TX using testpmd is increased by up to 20% over the original baseline.

Changes in V2:
* General minor updates follow comments on V1 set
* Updated a number of patches to include KNI mbuf changes where needed
* Deferred the patch to add the packet type field to a future patch set
* After removing meta-data element from mbuf structure also added in patch to move the macros to rte_port/rte_port.h

Bruce Richardson (11):
mbuf: reorder fields by time of use
mbuf: expand ol_flags field to 64-bits
mbuf: introduce a flag to indicate a control mbuf
mbuf: minor changes for readability
mbuf: use macros only to access the mbuf metadata
mbuf: add named points inside the mbuf structure
ixgbe: rework vector pmd following mbuf changes
mbuf: split mbuf across two cache lines.
mbuf: move l2_len and l3_len to second cache line
ixgbe: Fix perf regression due to moved pool ptr
ixgbe: Improve slow-path perf: vector scattered RX

Olivier Matz (1):
mbuf: replace data pointer by an offset

 app/test-pmd/config.c                              |   8 +-
 app/test-pmd/csumonly.c                            |  10 +-
 app/test-pmd/flowgen.c                             |   2 +-
 app/test-pmd/icmpecho.c                            |   2 +-
 app/test-pmd/ieee1588fwd.c                         |   4 +-
 app/test-pmd/macfwd-retry.c                        |   2 +-
 app/test-pmd/macfwd.c                              |   2 +-
 app/test-pmd/macswap.c                             |   2 +-
 app/test-pmd/rxonly.c                              |   4 +-
 app/test-pmd/testpmd.c                             |   2 +-
 app/test-pmd/testpmd.h                             |   4 +-
 app/test-pmd/txonly.c                              |   9 +-
 app/test/packet_burst_generator.c                  |   7 +-
 app/test/test_mbuf.c                               |   8 +-
 app/test/test_table_acl.c                          |   7 +-
 app/test/test_table_pipeline.c                     |   8 +-
 examples/exception_path/main.c                     |   3 +-
 examples/vhost/main.c                              |  37 +-
 examples/vhost_xen/main.c                          |  14 +-
 .../linuxapp/eal/include/exec-env/rte_kni_common.h |  20 +-
 lib/librte_eal/linuxapp/kni/kni_net.c              |  18 +-
 lib/librte_ip_frag/rte_ipv4_fragmentation.c        |   6 +-
 lib/librte_ip_frag/rte_ipv6_fragmentation.c        |   6 +-
 lib/librte_mbuf/rte_mbuf.c                         |  10 +-
 lib/librte_mbuf/rte_mbuf.h                         | 139 ++++----
 lib/librte_pmd_bond/rte_eth_bond_pmd.c             |   4 +-
 lib/librte_pmd_e1000/em_rxtx.c                     |  46 ++-
 lib/librte_pmd_e1000/igb_rxtx.c                    |  75 ++--
 lib/librte_pmd_i40e/i40e_rxtx.c                    |  48 +--
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c                  | 100 +++---
 lib/librte_pmd_ixgbe/ixgbe_rxtx.h                  |  24 +-
 lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c              | 389 +++++++++++++--------
 lib/librte_pmd_pcap/rte_eth_pcap.c                 |   9 +-
 lib/librte_pmd_virtio/virtio_rxtx.c                |  10 +-
 lib/librte_pmd_virtio/virtqueue.h                  |   3 +-
 lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c              |   5 +-
 lib/librte_pmd_xenvirt/rte_eth_xenvirt.c           |   2 +-
 37 files changed, 586 insertions(+), 463 deletions(-)
Signature · 1 line
1.9.3