Skip to content

sched: Always check the integrity of the canary

Aaron Tomlin linuxppc-dev lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v33 patches 13 repliesSuperseded
  3. v2 posting 2/23 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/23 patches0 repliesSuperseded
v12 patches5 repliesSuperseded

Changes in v4 from the cover letter

* Add Michael Ellerman's Acked-by to first patch (for powerpc)
* Fix compiler error - Michael Ellerman
* Set default Kconfig option to n - Michael Ellerman

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3init/main.c: Give init_task a canaryarch/powerpc/mm/fault.c arch/x86/mm/fault.c include/linux/sched.h +3 more+15 -101 reply
2/3sched: Add helper for task stack page overrun checkingarch/powerpc/mm/fault.c arch/x86/mm/fault.c include/linux/sched.h +1 more+5 -70 replies
3/3sched: BUG when stack end location is over writtenkernel/sched/core.c lib/Kconfig.debug+15 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMichael EllermanOleg Nesterov
1/3A-b A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] sched: Always check the integrity of the canary

Hi Peter,

Please let me know if this iteration is satisfactory. Thanks.

Currently in the event of a stack overrun a call to schedule() does not check for this type of corruption. This corruption is often silent and can go unnoticed. However once the corrupted region is examined at a later stage, the outcome is undefined and often results in a sporadic page fault which cannot be handled.

The first patch adds a canary to init_task's end of stack. While the second patch provides a helper to determine the integrity of the canary. The third checks for a stack overrun and takes appropriate action since the damage is already done, there is no point in continuing.

Changes since v3:

* Add Michael Ellerman's Acked-by to first patch (for powerpc)
* Fix compiler error - Michael Ellerman
* Set default Kconfig option to n - Michael Ellerman

Changes since v2:

* Use BUG_ON in schedule_debug() - Peter Zijlstra
* Use a more explicit function
name for setting the canary - Chuck Ebbert

Changes since v1:

* Rebased against v3.17-rc4
* Add a canary to init_task - Oleg Nesterov
* Fix various code formatting issues - Peter Zijlstra
* Introduce Kconfig option - Peter Zijlstra

Aaron Tomlin (3):
init/main.c: Give init_task a canary
sched: Add helper for task stack page overrun checking
sched: BUG when stack end location is over written

 arch/powerpc/mm/fault.c    |  5 +----
 arch/x86/mm/fault.c        |  5 +----
 include/linux/sched.h      |  4 ++++
 init/main.c                |  1 +
 kernel/fork.c              | 12 +++++++++---
 kernel/sched/core.c        |  3 +++
 kernel/trace/trace_stack.c |  4 +---
 lib/Kconfig.debug          | 12 ++++++++++++
 8 files changed, 32 insertions(+), 14 deletions(-)
Signature · 1 line
1.9.3