Skip to content

Bluetooth: SMP fixes/improvements

[email protected] linux-bluetooth 4 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 1 replyIn review
  2. v37 patches 0 repliesSuperseded
  3. v27 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Bluetooth: Remove unnecessary checks after canceling SMP security timernet/bluetooth/smp.c+1 -50 replies
2/8Bluetooth: Don't take any action in smp_resume_cb if not encryptednet/bluetooth/smp.c+4 -20 replies
3/8Bluetooth: Move identity address update behind a workqueueinclude/net/bluetooth/l2cap.h net/bluetooth/l2cap_core.c net/bluetooth/smp.c+11 -40 replies
4/8Bluetooth: Remove unnecessary deferred work for SMP key distributionnet/bluetooth/smp.c+5 -160 replies
5/8Bluetooth: Fix locking of the SMP contextinclude/net/bluetooth/hci_core.h net/bluetooth/smp.c+44 -330 replies
6/8Bluetooth: Add define for key distribution masknet/bluetooth/smp.c+3 -20 replies
7/8Bluetooth: Fix calling smp_distribute_keys() when still waiting for keysnet/bluetooth/smp.c+3 -20 replies
8/8Bluetooth: Add strict checks for allowed SMP PDUsnet/bluetooth/smp.c net/bluetooth/smp.h+84 -380 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/8] Bluetooth: SMP fixes/improvements

Hi,

This v4 adds has the following changes to previous revisions:

* Add KEY_DIST_MASK define to avoid hard-coded 0x07 values
* Update the last patch to use defines instead of helper functions
* Update the last patch to use a "drop:" label to simplify the if-statment used for dropping data.

Johan

----------------------------------------------------------------
Johan Hedberg (8):
Bluetooth: Remove unnecessary checks after canceling SMP security timer
Bluetooth: Don't take any action in smp_resume_cb if not encrypted
Bluetooth: Move identity address update behind a workqueue
Bluetooth: Remove unnecessary deferred work for SMP key distribution
Bluetooth: Fix locking of the SMP context
Bluetooth: Add define for key distribution mask
Bluetooth: Fix calling smp_distribute_keys() when still waiting for keys
Bluetooth: Add strict checks for allowed SMP PDUs

 include/net/bluetooth/hci_core.h |   1 -
 include/net/bluetooth/l2cap.h    |   3 +-
 net/bluetooth/l2cap_core.c       |  10 +-
 net/bluetooth/smp.c              | 225 +++++++++++++++++++++--------------
 net/bluetooth/smp.h              |   2 +
 5 files changed, 147 insertions(+), 94 deletions(-)