Clean-up of the systemd integration
Status from this message: NAK, as our current coding style is "2 space indents, tab=8" - even if
Get series with b4
b4 am [email protected]...Versions newest first
Patches in v1
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Don't let openvpn_popen() keep zombies aroundsrc/ | +5 | 2 replies | |
| 2/4 | Don't try to use systemd-ask-password if it is not availablesrc/ | +6 | 1 reply | |
| 3/4 | Clean up the pipe closing in openvpn_popen()src/ | +11 | 1 reply | |
| 4/4 | White-space clean-up of openvpn_popen()src/ | +41 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Openvpn-devel] [PATCH 0/4] Clean-up of the systemd integration
From: David Sommerseth <[email protected]...>
There were a few issues with the systemd implementation, where the openvpn binary would have zombie processes attached to itself when systemd-ask-password was used. In addition to not always properly closing the communcation pipes used.
This patch set also avoids OpenVPN failing if systemd-ask-password is not found, but rather falls back to the normal console method.
David Sommerseth (4):
Don't let openvpn_popen() keep zombies around Don't try to use systemd-ask-password if it is not available Clean up the pipe closing in openvpn_popen() White-space clean-up of openvpn_popen()
src/openvpn/console.c | 11 ++++---- src/openvpn/misc.c | 75 ++++++++++++++++++++++++++++----------------------- 2 files changed, 47 insertions(+), 39 deletions(-)
--
kind regards,
David Sommerseth
Signature · 1 line
1.8.3.1