Skip to content

Clean-up of the systemd integration

[email protected]... openvpn-devel 1 version NAK

Status from this message: NAK, as our current coding style is "2 space indents, tab=8" - even if

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest4 patches 5 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/4Don't let openvpn_popen() keep zombies aroundsrc/openvpn/misc.c+5 -22 replies
2/4Don't try to use systemd-ask-password if it is not availablesrc/openvpn/console.c+6 -51 reply
3/4Clean up the pipe closing in openvpn_popen()src/openvpn/misc.c+11 -81 reply
4/4White-space clean-up of openvpn_popen()src/openvpn/misc.c+41 -401 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/4] Clean-up of the systemd integration

From: David Sommerseth <[email protected]...>

There were a few issues with the systemd implementation, where the openvpn binary would have zombie processes attached to itself when systemd-ask-password was used. In addition to not always properly closing the communcation pipes used.

This patch set also avoids OpenVPN failing if systemd-ask-password is not found, but rather falls back to the normal console method.

David Sommerseth (4):
Don't let openvpn_popen() keep zombies around Don't try to use systemd-ask-password if it is not available Clean up the pipe closing in openvpn_popen() White-space clean-up of openvpn_popen()

 src/openvpn/console.c | 11 ++++----
 src/openvpn/misc.c    | 75 ++++++++++++++++++++++++++++-----------------------
 2 files changed, 47 insertions(+), 39 deletions(-)

--
kind regards,

David Sommerseth

Signature · 1 line
1.8.3.1