Skip to content

introduce max_transfer_length

Peter Lieven qemu-devel 6 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 3 repliesApplied
  2. v56 patches 10 repliesSuperseded
  3. v44 patches 8 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches0 repliesSuperseded
v24 patches0 repliesSuperseded
v14 patches39 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/6util: introduce MIN_NON_ZEROinclude/qemu/osdep.h+6 -00 replies
2/6BlockLimits: introduce max_transfer_lengthblock.c include/block/block_int.h+7 -00 replies
3/6block/iscsi: set max_transfer_lengthblock/iscsi.c+15 -21 reply
4/6block: avoid creating oversized writes in multiwrite_mergeblock.c+5 -00 replies
5/6block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limitsblock/iscsi.c+10 -101 reply
6/6block/iscsi: check for oversized requestsblock/iscsi.c+12 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchMax ReitzRonnie Sahlberg
1/6R-b
2/6R-b
3/6R-b
4/6R-b R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length

This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix.

Splitting up requests according to the max_transfer_length will follow in a later series.

v5->v6: - fix parentheses in Patch 1 [Max]
- rename helper function in Patch 3 [Max]
- cap the limits to highest power of 2 fitting in INT_MAX [Max]
- removed full stops in error messages in Patch 6 [Max]

v4->v5: - Added check for (a != 0 instead of !!a) [Max] and some comments [Eric]
- Correctly limited max_transfer_length to INT_MAX in Patch 3 [Max]
- Added Patch 5 and Patch 6.

v3->v4: introduce MIN_NON_ZERO to correctly calculate minimum of 2 limits. v2->v3: remove Patch 2 completely [Paolo]
v1->v2: do not throw errors but generate trace events in Patch 2 [Paolo]

Peter Lieven (6):
util: introduce MIN_NON_ZERO
BlockLimits: introduce max_transfer_length block/iscsi: set max_transfer_length
block: avoid creating oversized writes in multiwrite_merge block/iscsi: use sector_limits_lun2qemu throughout
iscsi_refresh_limits
block/iscsi: check for oversized requests

 block.c                   |    9 +++++++++
 block/iscsi.c             |   49 ++++++++++++++++++++++++++++++++++-----------
 include/block/block_int.h |    3 +++
 include/qemu/osdep.h      |    6 ++++++
 4 files changed, 55 insertions(+), 12 deletions(-)
Signature · 1 line
1.7.9.5