Skip to content

tcp: deduplicate TCP_SKB_CB(skb)->when

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tcp: introduce TCP_SKB_CB(skb)->tcp_tw_isninclude/net/tcp.h net/ipv4/tcp_input.c net/ipv4/tcp_ipv4.c +2 more+11 -61 reply
2/2tcp: remove TCP_SKB_CB(skb)->wheninclude/net/tcp.h net/ipv4/tcp_input.c net/ipv4/tcp_ipv4.c +2 more+31 -361 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchYuchung Cheng
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/2] tcp: deduplicate TCP_SKB_CB(skb)->when

TCP_SKB_CB(skb)->when has different meaning in output and input paths.

In output path, it contains a timestamp.
In input path, it contains an ISN, chosen by tcp_timewait_state_process()

Its usage in output path is obsolete after usec timestamping. Lets simplify and clean this.

Eric Dumazet (2):
tcp: introduce TCP_SKB_CB(skb)->tcp_tw_isn
tcp: remove TCP_SKB_CB(skb)->when

 include/net/tcp.h        |  8 +++++++-
 net/ipv4/tcp_input.c     |  5 +++--
 net/ipv4/tcp_ipv4.c      |  7 ++++---
 net/ipv4/tcp_minisocks.c |  2 +-
 net/ipv4/tcp_output.c    | 34 +++++++++++++---------------------
 net/ipv4/tcp_timer.c     |  7 +++----
 net/ipv6/tcp_ipv6.c      |  4 ++--
 7 files changed, 33 insertions(+), 34 deletions(-)
Signature · 1 line
2.1.0.rc2.206.gedb03e5