Skip to content

clean up collapse range and handle post-eof delalloc

Brian Foster linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesIn review
  2. v14 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Rename helpers to xfs_bmse_*() scheme.
- Rearrange logic and minor cleanups to xfs_bmse[_can]_merge().
- Inserted patch 3 to further refactor xfs_bmap_shift_extents() into xfs_bmse_shift_one().
- Return corruption error rather than BUG_ON() in patch 4 and detect error in new helper.
v1: http://oss.sgi.com/archives/xfs/2014-09/msg00061.html
- Retain the eofblocks trim and writeback/inval. the range of shifted data only.
- Added the xfs_free_file_space() patch to no longer writeback the entire file.
rfc: http://oss.sgi.com/archives/xfs/2014-08/msg00462.html

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xfs: track collapse via file offset rather than extent indexfs/xfs/libxfs/xfs_bmap.c fs/xfs/libxfs/xfs_bmap.h fs/xfs/xfs_bmap_util.c+53 -510 replies
2/5xfs: refactor shift-by-merge into xfs_bmse_merge() helperfs/xfs/libxfs/xfs_bmap.c+167 -750 replies
3/5xfs: refactor single extent shift into xfs_bmse_shift_one() helperfs/xfs/libxfs/xfs_bmap.c+91 -730 replies
4/5xfs: writeback and inval. file range to be shifted by collapsefs/xfs/libxfs/xfs_bmap.c fs/xfs/xfs_bmap_util.c+23 -130 replies
5/5xfs: only writeback and truncate pages for the freed rangefs/xfs/xfs_bmap_util.c+6 -40 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDave ChinnerBrian Foster
SeriesR-b
1/5R-b
2/5
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] clean up collapse range and handle post-eof delalloc

Hi all,

Here's v2 of the collapse clean up. We refactor a bit more via the insertion of patch 3, otherwise it's similar to v1. This will see some continued testing, but it survived ~500m fsx operations overnight.

Brian

v2:
- Rename helpers to xfs_bmse_*() scheme.
- Rearrange logic and minor cleanups to xfs_bmse[_can]_merge().
- Inserted patch 3 to further refactor xfs_bmap_shift_extents() into xfs_bmse_shift_one().
- Return corruption error rather than BUG_ON() in patch 4 and detect error in new helper.
v1: http://oss.sgi.com/archives/xfs/2014-09/msg00061.html
- Retain the eofblocks trim and writeback/inval. the range of shifted data only.
- Added the xfs_free_file_space() patch to no longer writeback the entire file.
rfc: http://oss.sgi.com/archives/xfs/2014-08/msg00462.html

Brian Foster (5):
xfs: track collapse via file offset rather than extent index
xfs: refactor shift-by-merge into xfs_bmse_merge() helper
xfs: refactor single extent shift into xfs_bmse_shift_one() helper
xfs: writeback and inval. file range to be shifted by collapse
xfs: only writeback and truncate pages for the freed range

 fs/xfs/libxfs/xfs_bmap.c | 365 +++++++++++++++++++++++++++++++----------------
 fs/xfs/libxfs/xfs_bmap.h |   7 +-
 fs/xfs/xfs_bmap_util.c   |  54 ++++---
 3 files changed, 275 insertions(+), 151 deletions(-)
Signature · 6 lines
1.8.3.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs