Skip to content

RFC perf pollfd v3

Arnaldo Carvalho de Melo lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest14 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14perf evlist: Introduce perf_evlist__filter_pollfd methodtools/perf/util/evlist.c tools/perf/util/evlist.h+23 -00 replies
2/14perf tests: Add test for perf_evlist__filter_pollfd()tools/perf/Makefile.perf tools/perf/tests/builtin-test.c tools/perf/tests/evlist.c +1 more+109 -00 replies
3/14perf evlist: Monitor POLLERR and POLLHUP events tootools/perf/util/evlist.c+1 -10 replies
4/14perf evlist: We need to poll all event file descriptorstools/perf/util/evlist.c+2 -20 replies
5/14perf record: Filter out POLLHUP'ed file descriptorstools/perf/builtin-record.c+3 -00 replies
6/14perf trace: Filter out POLLHUP'ed file descriptorstools/perf/builtin-trace.c+2 -10 replies
7/14perf evlist: Allow growing pollfd on add methodtools/perf/util/evlist.c tools/perf/util/evlist.h+36 -70 replies
8/14perf tests: Add pollfd growing testtools/perf/tests/builtin-test.c tools/perf/tests/evlist.c tools/perf/tests/tests.h+116 -00 replies
9/14perf kvm stat live: Use perf_evlist__add_pollfd() instead of local equivalenttools/perf/builtin-kvm.c+9 -130 replies
10/14perf evlist: Introduce poll method for common code idiomtools/perf/builtin-record.c tools/perf/builtin-top.c tools/perf/builtin-trace.c +6 more+15 -80 replies
11/14tools lib api: Adopt fdarray class from perf's evlisttools/lib/api/Makefile tools/lib/api/fd/array.c tools/lib/api/fd/array.h +5 more+195 -8911 replies
12/14perf evlist: Refcount mmapstools/perf/util/evlist.c tools/perf/util/evlist.h+26 -10 replies
13/14tools lib fd array: Allow associating an integer cookie with each entrytools/lib/api/fd/array.c tools/lib/api/fd/array.h tools/perf/util/evlist.c+28 -67 replies
14/14perf evlist: Unmap ring buffer when fd is nukedtools/perf/util/evlist.c+26 -32 replies

Reviews trailers per patch

9 of 14 patches have a Reviewed-by or Acked-by.

PatchJiri OlsaDavid AhernPeter Zijlstra
1/14A-b
2/14A-b
3/14A-b
4/14
5/14A-b
6/14A-b
7/14
8/14A-b
9/14A-b R-b
10/14A-b
11/14A-b
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC 00/14] perf pollfd v3

From: Arnaldo Carvalho de Melo <[email protected]>

Hi,

Main different to what was discussed in v2[1]:

Poll all event file descriptors, not just the ones mmaped.

This is a bug that was present before, noticed by Adrian Hunter while
reviewing this patchkit, i.e. we were polling just the mmaped ones, because then we would look at all the ring buffers when just one of the polled descriptors was ready to read.

But this could lead to delays in polling when one of the mmaped fds was
closed and we would then not be notified when another, associated to it by means of PERF_EVENT_IOC_SET_OUTPUT, had events available.

Also refcount the mmaps associated by means of PERF_EVENT_IOC_SET_OUTPUT,
so that we can properly unmap a ring buffer to which all its file descriptors had been closed, for longer running apps.

It is all available on my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/fdarray.v2

I kept the v3 for the series as I initially called it pollfd, but since the
class that grew out of it was named fdarray, thus the fdarray.v2 branch name.

Please let me know if there are still any other problems, now back to
fixing up my last perf/core pull req wrt those external proggies problems.

- Arnaldo

[1] http://lkml.kernel.org/r/[email protected]

Arnaldo Carvalho de Melo (14):
perf evlist: Introduce perf_evlist__filter_pollfd method
perf tests: Add test for perf_evlist__filter_pollfd()
perf evlist: Monitor POLLERR and POLLHUP events too
perf evlist: We need to poll all event file descriptors
perf record: Filter out POLLHUP'ed file descriptors
perf trace: Filter out POLLHUP'ed file descriptors
perf evlist: Allow growing pollfd on add method
perf tests: Add pollfd growing test
perf kvm stat live: Use perf_evlist__add_pollfd() instead of local equivalent perf evlist: Introduce poll method for common code idiom
tools lib api: Adopt fdarray class from perf's evlist
perf evlist: Refcount mmaps
tools lib fd array: Allow associating an integer cookie with each entry perf evlist: Unmap ring buffer when fd is nuked

 tools/lib/api/Makefile                    |   7 +-
 tools/lib/api/fd/array.c                  | 128 ++++++++++++++++++
 tools/lib/api/fd/array.h                  |  34 +++++
 tools/perf/Makefile.perf                  |   1 +
 tools/perf/builtin-kvm.c                  |  24 ++--
 tools/perf/builtin-record.c               |   5 +-
 tools/perf/builtin-top.c                  |   4 +-
 tools/perf/builtin-trace.c                |   3 +-
 tools/perf/tests/builtin-test.c           |   8 ++
 tools/perf/tests/evlist.c                 | 217 ++++++++++++++++++++++++++++++
 tools/perf/tests/open-syscall-tp-fields.c |   2 +-
 tools/perf/tests/perf-record.c            |   2 +-
 tools/perf/tests/task-exit.c              |   2 +-
 tools/perf/tests/tests.h                  |   2 +
 tools/perf/util/evlist.c                  |  77 +++++++++--
 tools/perf/util/evlist.h                  |  16 ++-
 tools/perf/util/python.c                  |   6 +-
 17 files changed, 499 insertions(+), 39 deletions(-)
 create mode 100644 tools/lib/api/fd/array.c
 create mode 100644 tools/lib/api/fd/array.h
 create mode 100644 tools/perf/tests/evlist.c
Signature · 1 line
1.9.3