Skip to content

Time related fixes for 3.17/stable

John Stultz lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4jiffies: Fix timeval conversion to jiffiesinclude/linux/jiffies.h kernel/time/time.c+31 -370 replies
2/4alarmtimer: Return relative times in timer_gettimekernel/time/alarmtimer.c+11 -70 replies
3/4alarmtimer: Do not signal SIGEV_NONE timerskernel/time/alarmtimer.c+4 -20 replies
4/4alarmtimer: Lock k_itimer during timer callbackkernel/time/alarmtimer.c+8 -20 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchPaul Turner
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Time related fixes for 3.17/stable

Hey Thomas, Ingo,

Here are a few fixes for 3.17/stable that came in over the last week or so.

The first is a fix to the timeval to jiffies conversion that was incorrectly rounding up by one even when the value divided precisely. This issue is apparently quite long standing, but shows up as in increasing timeout when folks re-use the returned old_value from setitimer.

The second group are yet further fixes to the alarmtimer code. This time catching incorrect timer_gettime semantics as well as fixes for improper signaling and locking. These all go back to 3.0, and the timer_gettime change could cause problems with existing apps, but I suspect that aspect of the interface hasn't been used much until recently.

These are against tip/timers/urgent, and have run successfully through my timekeeping tests for x86_64, i386 and arm.

Let me know if you have any comments or objections.

thanks
-john

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Richard Cochran <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Sharvil Nanavati <[email protected]>
Cc Paul Turner <[email protected]>
Cc Andrew Hunter <[email protected]>
Cc Aaron Jacobs <[email protected]>
Cc Richard Larocque <[email protected]>

Pull request below if you'd prefer to take it that way:

The following changes since commit 9bf2419fa7bffa16ce58a4d5c20399eff8c970c9:
timekeeping: Update timekeeper before updating vsyscall and pvclock (2014-09-06 12:58:18 +0200)

are available in the git repository at:

https://git.linaro.org/people/john.stultz/linux.git fortglx/3.17/time

for you to fetch changes up to 474e941bed9262f5fa2394f9a4a67e24499e5926:

alarmtimer: Lock k_itimer during timer callback (2014-09-12 13:59:12 -0700)

----------------------------------------------------------------
Andrew Hunter (1):
jiffies: Fix timeval conversion to jiffies

Richard Larocque (3):
alarmtimer: Return relative times in timer_gettime
alarmtimer: Do not signal SIGEV_NONE timers
alarmtimer: Lock k_itimer during timer callback

 include/linux/jiffies.h  | 12 ------------
 kernel/time/alarmtimer.c | 34 +++++++++++++++++++++++-----------
 kernel/time/time.c       | 56 +++++++++++++++++++++++++++++++-------------------------
 3 files changed, 54 insertions(+), 48 deletions(-)

Andrew Hunter (1):
jiffies: Fix timeval conversion to jiffies

Richard Larocque (3):
alarmtimer: Return relative times in timer_gettime
alarmtimer: Do not signal SIGEV_NONE timers
alarmtimer: Lock k_itimer during timer callback

 include/linux/jiffies.h  | 12 -----------
 kernel/time/alarmtimer.c | 34 +++++++++++++++++++----------
 kernel/time/time.c       | 56 +++++++++++++++++++++++++++---------------------
 3 files changed, 54 insertions(+), 48 deletions(-)
Signature · 1 line
1.9.1