Skip to content

RFC AHCI Device improvements

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ide: add is_write() macro for semantic consistencyhw/ide/core.c hw/ide/internal.h+3 -12 replies
2/10AHCI: Update byte count after DMA completiondma-helpers.c hw/ide/ahci.c hw/ide/core.c +2 more+53 -153 replies
3/10AHCI: Add PRD interrupthw/ide/ahci.c hw/ide/ahci.h+15 -15 replies
4/10ide: Correct handling of malformed/short PRDTsdma-helpers.c hw/ide/ahci.c hw/ide/core.c +1 more+8 -31 reply
5/10AHCI: Rename NCQFIS structure fieldshw/ide/ahci.c hw/ide/ahci.h+74 -140 replies
6/10AHCI: Fix FIS decompositionhw/ide/ahci.c+26 -380 replies
7/10ide/ahci: Reorder error cases in handle_cmdhw/ide/ahci.c+13 -151 reply
8/10ahci: Check cmd_fis[1] more explicitlyhw/ide/ahci.c+12 -111 reply
9/10ahci: factor out FIS decompositionhw/ide/ahci.c+86 -831 reply
10/10AHCI: Fix SDB FIS Constructionhw/ide/ahci.c hw/ide/ahci.h+20 -110 replies

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchPaolo Bonzini
1/10
2/10
3/10
4/10R-b
5/10
6/10
7/10R-b
8/10R-b
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [RFC 00/10] AHCI Device improvements

This patch series collects a number of fixes centered around improving the AHCI device.

A number of them used to be tied to as-yet unposted ahci-test patches, but I have separated them out in order to post them standalone and collect feedback.

This series as a whole fixes a number of crashes, bugs, and some specification issues that were a problem mostly in unit testing, though several observable problems with real guests are fixed by this series:

(1) Byte count after DMA completion fixes Windows 7 hibernate as well as non-ncq BSODs.

(2) FIS decomposition fixes prevent corruption when reading from / writing to sectors located beyond the LBA28 limit.
(Reported by Eniac Zhang <[email protected]>)

(3) SDB_FIS construction issues may be partly responsible for unreliable NCQ operation within windows.

John Snow (10):
ide: add is_write() macro for semantic consistency
AHCI: Update byte count after DMA completion
AHCI: Add PRD interrupt
ide: Correct handling of malformed/short PRDTs
AHCI: Rename NCQFIS structure fields
AHCI: Fix FIS decomposition
ide/ahci: Reorder error cases in handle_cmd
ahci: Check cmd_fis[1] more explicitly
ahci: factor out FIS decomposition
AHCI: Fix SDB FIS Construction

 dma-helpers.c        |   8 ++
 hw/ide/ahci.c        | 337 +++++++++++++++++++++++++++++++--------------------
 hw/ide/ahci.h        |  51 ++++++--
 hw/ide/core.c        |  17 ++-
 hw/ide/internal.h    |   3 +
 hw/ide/pci.c         |   5 +-
 include/sysemu/dma.h |   1 +
 7 files changed, 270 insertions(+), 152 deletions(-)
Signature · 1 line
1.9.3