RFC AHCI Device improvements
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest10 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | ide: add is_write() macro for semantic consistencyhw/ hw/ | +3 | 2 replies | |
| 2/10 | AHCI: Update byte count after DMA completiondma-helpers.c hw/ hw/ +2 more | +53 | 3 replies | |
| 3/10 | AHCI: Add PRD interrupthw/ hw/ | +15 | 5 replies | |
| 4/10 | ide: Correct handling of malformed/short PRDTsdma-helpers.c hw/ hw/ +1 more | +8 | 1 reply | |
| 5/10 | AHCI: Rename NCQFIS structure fieldshw/ hw/ | +74 | 0 replies | |
| 6/10 | AHCI: Fix FIS decompositionhw/ | +26 | 0 replies | |
| 7/10 | ide/ahci: Reorder error cases in handle_cmdhw/ | +13 | 1 reply | |
| 8/10 | ahci: Check cmd_fis[1] more explicitlyhw/ | +12 | 1 reply | |
| 9/10 | ahci: factor out FIS decompositionhw/ | +86 | 1 reply | |
| 10/10 | AHCI: Fix SDB FIS Constructionhw/ hw/ | +20 | 0 replies |
Reviews trailers per patch
4 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini |
|---|---|
| 1/10 | |
| 2/10 | |
| 3/10 | |
| 4/10 | R-b |
| 5/10 | |
| 6/10 | |
| 7/10 | R-b |
| 8/10 | R-b |
| 9/10 | R-b |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [RFC 00/10] AHCI Device improvements
This patch series collects a number of fixes centered around improving the AHCI device.
A number of them used to be tied to as-yet unposted ahci-test patches, but I have separated them out in order to post them standalone and collect feedback.
This series as a whole fixes a number of crashes, bugs, and some specification issues that were a problem mostly in unit testing, though several observable problems with real guests are fixed by this series:
(1) Byte count after DMA completion fixes Windows 7 hibernate as well as non-ncq BSODs.
(2) FIS decomposition fixes prevent corruption when reading from / writing to sectors located beyond the LBA28 limit.
(Reported by Eniac Zhang <[email protected]>)
(3) SDB_FIS construction issues may be partly responsible for unreliable NCQ operation within windows.
John Snow (10):
ide: add is_write() macro for semantic consistency
AHCI: Update byte count after DMA completion
AHCI: Add PRD interrupt
ide: Correct handling of malformed/short PRDTs
AHCI: Rename NCQFIS structure fields
AHCI: Fix FIS decomposition
ide/ahci: Reorder error cases in handle_cmd
ahci: Check cmd_fis[1] more explicitly
ahci: factor out FIS decomposition
AHCI: Fix SDB FIS Construction
dma-helpers.c | 8 ++ hw/ide/ahci.c | 337 +++++++++++++++++++++++++++++++-------------------- hw/ide/ahci.h | 51 ++++++-- hw/ide/core.c | 17 ++- hw/ide/internal.h | 3 + hw/ide/pci.c | 5 +- include/sysemu/dma.h | 1 + 7 files changed, 270 insertions(+), 152 deletions(-)
Signature · 1 line
1.9.3