Skip to content

bonding: style, comment and assertion changes

Nikolay Aleksandrov netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bonding: consolidate the two rlb_next_rx_slave functions into onedrivers/net/bonding/bond_alb.c+10 -280 replies
2/3bonding: trivial: style and comment fixesdrivers/net/bonding/bond_3ad.c drivers/net/bonding/bond_alb.c drivers/net/bonding/bond_debugfs.c +3 more+93 -1670 replies
3/3bonding: consolidate ASSERT_RTNL()s and remove the unnecessarydrivers/net/bonding/bond_main.c+2 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] bonding: style, comment and assertion changes

Hi all,
This is a small and simple patch-set that doesn't introduce (hopefully) any functional changes, but only stylistic and semantic ones.
Patch 01 simply uses the already provided __rlb_next_rx_slave function inside rlb_next_rx_slave(), thus removing the duplication of code.
Patch 02 changes all comments that I could find to netdev style, removes some outdated ones and fixes a few more small cosmetic issues (new line after declaration, braces around if; else and such)
Patch 03 removes one extra ASSERT_RTNL() because we already have it in the parent function and consolidates two other ASSERT_RTNL()s to the function that is exported and supposed to be called with RTNL anyway.

Best regards,
Nikolay Aleksandrov

Nikolay Aleksandrov (3):
bonding: consolidate the two rlb_next_rx_slave functions into one
bonding: trivial: style and comment fixes
bonding: consolidate ASSERT_RTNL()s and remove the unnecessary

 drivers/net/bonding/bond_3ad.c     |   5 +-
 drivers/net/bonding/bond_alb.c     |  86 ++++++----------
 drivers/net/bonding/bond_debugfs.c |   4 +-
 drivers/net/bonding/bond_main.c    | 205 +++++++++++++------------------------
 drivers/net/bonding/bond_sysfs.c   |   1 -
 drivers/net/bonding/bonding.h      |   3 +-
 6 files changed, 105 insertions(+), 199 deletions(-)
Signature · 1 line
1.9.3