Skip to content

xfstests: cleanups and new tests.

Dave Chinner fstests linux-ext4 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5generic: more tests should clean up TESTDIR on successtests/generic/074 tests/generic/247 tests/xfs/020+22 -151 reply
2/5check: more tests that shouldn't check the scratch devicetests/xfs/200+1 -11 reply
3/5generic: add mmap write vs truncate testtests/generic/029 tests/generic/029.out tests/generic/group+189 -01 reply
4/5generic: add mmap write vs truncate/remap testtests/generic/030 tests/generic/030.out tests/generic/group+202 -06 replies
5/5generic: add write vs fcollapse testtests/generic/031 tests/generic/031.out tests/generic/group+93 -02 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchEric Sandeen
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] xfstests: cleanups and new tests.

Hi y'all,

The first two patches are minor cleanup patches. The first changes some tests that can leave large deposits on the test fs when they fail and that can lead to ENOSPC issues on small test devices. The second is another test that shouldn't check the scratch device at the end.

The remaining three patches are new generic tests that exercise data corruption issues that we've tripped over in the past week on XFS. The test cases have been isolated by Brian Foster and Eric Sandeen - they deserve the credit for narrowing down the minimal tests to expose the problems. I just added a few more corner cases and packaged them for xfstests.

These failures manifest on block size smaller than page size filesystems, and we have XFS fixes pending for these failures:

http://oss.sgi.com/pipermail/xfs/2014-September/038191.html
http://oss.sgi.com/pipermail/xfs/2014-September/038167.html

Ext4 folks, can you confirm that both the truncate tests fail on ext4 with data corruption on 1k/2k filesystems? I'm pretty sure that I have the corrupt hexdump outputs in the golden output files for the tests and if I have that means ext4 is corrupting data in a similar manner to XFS. Eric is already looking at this but could probably use some more help. ;)

-Dave.