Skip to content

tg3: Fix handling of non-acceleration vlans

Vladislav Yasevich netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v11 patch 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tg3: Work around HW/FW limitations with vlan encapsulated framesdrivers/net/ethernet/broadcom/tg3.c+17 -00 replies
2/2tg3: Allow for receive of full-size 8021AD framesdrivers/net/ethernet/broadcom/tg3.c+2 -13 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPrashant Sreedharan
SeriesA-b A-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] tg3: Fix handling of non-acceleration vlans

TG3 can't cope with checksum and TSO offloads when vlan headers were not accelerated. This can be demonstrated with 802.1ad vlans or by configuring a vlan on top of a bridge and turning off vlan acceleration on the bridge device.

Instead of disabling all vlan acceleration, this series works around the issue by having tg3 driver call software segmentation and checksum generation.

v2: - moved the call to software segment soonner
- Preserve the checksum flags for TSO/LSO case and turn it off if software checksum was computed.
- Add code to correctly receive full sized 802.1ad frames.

Vladislav Yasevich (2):
tg3: Work around HW/FW limitations with vlan encapsulated frames
tg3: Allow for receive of full-size 8021AD frames

 drivers/net/ethernet/broadcom/tg3.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.3