Skip to content

perf tools: Add call-graph config options (v2)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5perf hists browser: Fix callchain print bug on TUItools/perf/ui/browsers/hists.c+0 -30 replies
2/5perf tools: Move callchain config from record_opts to callchain_paramtools/perf/builtin-record.c tools/perf/builtin-top.c tools/perf/perf.h +2 more+30 -380 replies
3/5perf tools: Move some callchain parser functions to callchain.ctools/perf/builtin-record.c tools/perf/builtin-top.c tools/perf/util/callchain.c +1 more+88 -882 replies
4/5perf tools: Introduce perf_callchain_config()tools/perf/util/callchain.c tools/perf/util/callchain.h tools/perf/util/config.c+94 -190 replies
5/5perf tools: Convert {record,top}.call-graph option to call-graph.record-modetools/perf/builtin-record.c tools/perf/builtin-top.c+2 -20 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid AhernJiri OlsaNamhyung Kim
SeriesA-b
1/5R-b A-b
2/5R-b A-b
3/5R-b A-b
4/5R-b A-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCHSET 0/5] perf tools: Add call-graph config options (v2)

Hello,

This is patchset to add new callchain related config options so that users don't need to pass their preference to the cmdline everytime.

Following config options will be added, and users can set appropriate values to ~/.perfconfig file. Note that the dump-size option is meaningful only if record-mode = dwarf.

  $ cat ~/.perfconfig
  [call-graph]
    record-mode = dwarf
    dump-size = 4096
    print-type = graph
    order = callee
    threshold = 0.5
    print-limit = 128
    sort-key = function
  $ perf record -vg sleep 1
  callchain: type DWARF
  callchain: stack dump size 4096
  mmap size 528384B
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.054 MB perf.data (~2378 samples) ]
  Looking at the vmlinux_path (7 entries long)
  Using /lib/modules/3.16.3-1-ARCH/build/vmlinux for symbols

Jiri and David, I kept your Acked-by and Reviewed-by in this version. Please take a look at the patch 4/5 which splits parser functions that it still looks okay to you.

changes in v2)
* use sizeof("call-graph.") instead of hardcoding the length (Jiri)
* split parse functions so that only handle relavant options
* add Acked/Reviewed-by tags from David and Jiri

You can also get this from 'perf/callchain-config-v2' branch on my tree

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcomed, thanks
Namhyung

Namhyung Kim (5):
perf hists browser: Fix callchain print bug on TUI
perf tools: Move callchain config from record_opts to callchain_param perf tools: Move some callchain parser functions to callchain.c perf tools: Introduce perf_callchain_config()
perf tools: Convert {record,top}.call-graph option to
call-graph.record-mode

 tools/perf/builtin-record.c    | 119 ++++---------------------
 tools/perf/builtin-top.c       |   4 +-
 tools/perf/perf.h              |   3 -
 tools/perf/ui/browsers/hists.c |   3 -
 tools/perf/util/callchain.c    | 193 +++++++++++++++++++++++++++++++++++++----
 tools/perf/util/callchain.h    |   6 +-
 tools/perf/util/config.c       |   3 +
 tools/perf/util/evsel.c        |  11 ++-
 8 files changed, 203 insertions(+), 139 deletions(-)
Signature · 1 line
2.1.0