complete conversion to hotplug-handler API
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest36 patches 33 repliesIn review
- v130 patches 67 repliesSuperseded
Changes in v2 from the cover letter
* added usb-uas test
* drop hotplug check in bus_add_child()
* make SCSI & USB bus as default HotplugHandler
* fixed dummy HBA hot(un)plug
* fixed hotunplug on s390x
* prevent hotplug of non hotpluggable devices
--
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/36 | test: virtio-scsi: check if hot-plug/unplug workstests/ | +29 | 0 replies | |
| 2/36 | test: virtio-serial: check if hot-plug/unplug workstests/ | +27 | 0 replies | |
| 3/36 | test: libqos: add qpci_plug_device_test() and qpci_unplug_acpi_device_test()tests/ tests/ | +52 | 0 replies | |
| 4/36 | test: virtio-rng: check if hot-plug/unplug workstests/ tests/ | +11 | 0 replies | |
| 5/36 | test: virtio-net: check if hot-plug/unplug workstests/ tests/ | +11 | 0 replies | |
| 6/36 | test: virtio-blk: check if hot-plug/unplug workstests/ | +38 | 0 replies | |
| 7/36 | test: usb: move uhci port test code to libqos/usb.ctests/ tests/ tests/ +1 more | +58 | 0 replies | |
| 8/36 | test: usb: add port test to uhci unit testtests/ tests/ | +17 | 0 replies | |
| 9/36 | test: usb: generic usb device hotplugtests/ tests/ tests/ +4 more | +87 | 0 replies | |
| 10/36 | test: usb: usb-storage hotplug testtests/ | +31 | 0 replies | |
| 11/36 | test: usb: usb-uas hotplug testtests/ | +60 | 0 replies | |
| 12/36 | access BusState.allow_hotplug using wraper qbus_is_hotpluggable()hw/ hw/ hw/ +2 more | +12 | 0 replies | |
| 13/36 | qdev: do not allow to instantiate non hotpluggable device with device_addqdev-monitor.c | +2 | 1 reply | |
| 14/36 | qdev: HotplugHandler: rename unplug callback to unplug_requesthw/ hw/ hw/ +8 more | +32 | 1 reply | |
| 15/36 | qdev: HotplugHandler: provide unplug callbackhw/ hw/ include/ | +34 | 0 replies | |
| 16/36 | qdev: add simple/generic unplug callback for HotplugHandlerhw/ include/ | +7 | 0 replies | |
| 17/36 | qdev: add wrapper to set BUS as HotplugHandlerhw/ include/ | +23 | 1 reply | |
| 18/36 | qdev: drop hotplug check from bus_add_child()hw/ | +0 | 1 reply | |
| 19/36 | target-i386: ICC bus: drop BusState.allow_hotplughw/ | +0 | 1 reply | |
| 20/36 | virtio-pci: drop BusState.allow_hotplughw/ | +0 | 0 replies | |
| 21/36 | virtio-serial: convert to hotplug-handler APIhw/ | +15 | 0 replies | |
| 22/36 | virtio-mmio: drop useless bus->allow_hotplug = 0hw/ | +2 | 0 replies | |
| 23/36 | s390x: drop not used allow_hotplug in event-facilityhw/ | +0 | 1 reply | |
| 24/36 | s390x: convert s390-virtio to hotplug handler APIhw/ | +7 | 8 replies | |
| 25/36 | s390x: convert virtio-ccw to hotplug handler APIhw/ | +9 | 1 reply | |
| 26/36 | scsi: set SCSI BUS itself as default HotplugHandlerhw/ | +7 | 0 replies | |
| 27/36 | scsi: convert pvscsi HBA to hotplug handler APIhw/ | +18 | 0 replies | |
| 28/36 | scsi: convert virtio-scsi HBA to hotplug handler APIhw/ | +20 | 0 replies | |
| 29/36 | scsi: cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fieldshw/ include/ | +0 | 0 replies | |
| 30/36 | usb-bot: mark device as non hotpluggablehw/ | +2 | 0 replies | |
| 31/36 | usb-bot: drop not needed "allow_hotplug = 0"hw/ | +0 | 0 replies | |
| 32/36 | usb-storage: drop not needed "allow_hotplug = 0"hw/ | +0 | 0 replies | |
| 33/36 | usb: convert usb-ccid to hotplug handler APIhw/ | +7 | 0 replies | |
| 34/36 | usb: convert usb devices to hotplug handler APIhw/ | +7 | 0 replies | |
| 35/36 | qdev: drop legacy hotplug fields/methodshw/ include/ | +4 | 0 replies | |
| 36/36 | qdev: HotplugHandler: add support for unplugging BUS-less deviceshw/ | +34 | 6 replies |
Reviews trailers per patch
18 of 36 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paolo Bonzini | Cornelia Huck | Michael S. Tsirkin |
|---|---|---|---|
| Series | R-b | R-b | |
| 1/36 | R-b | ||
| 2/36 | R-b | ||
| 3/36 | |||
| 4/36 | |||
| 5/36 | |||
| 6/36 | |||
| 7/36 | |||
| 8/36 | |||
| 9/36 | |||
| 10/36 | |||
| 11/36 | |||
| 12/36 | R-b | ||
| 13/36 | R-b | ||
| 14/36 | R-b | R-b | |
| 15/36 | R-b | ||
| 16/36 | R-b | ||
| 17/36 | R-b | ||
| 18/36 | R-b | ||
| 19/36 | R-b | ||
| 20/36 | |||
| 21/36 | R-b | ||
| 22/36 | R-b | ||
| 23/36 | R-b | R-b | |
| 24/36 | R-b | ||
| 25/36 | R-b | ||
| 26/36 | |||
| 27/36 | |||
| 28/36 | |||
| 29/36 | R-b | ||
| 30/36 | |||
| 31/36 | |||
| 32/36 | R-b | ||
| 33/36 | |||
| 34/36 | |||
| 35/36 | R-b | ||
| 36/36 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API
Changes since v1:
* added usb-uas test
* drop hotplug check in bus_add_child()
* make SCSI & USB bus as default HotplugHandler
* fixed dummy HBA hot(un)plug
* fixed hotunplug on s390x
* prevent hotplug of non hotpluggable devices
--
Series unifies different hotplug mechanisms to a recent hotplug-handler API and does shallow conversion of devices that still use legacy qdev hotplug to it dropping not used after that legacy hotplug path [29/30]. It also relaces SCSI's own way to do hotplug/unplug with hotplug-handler callbacks leaving it the only method perform hotplug tasks.
And the last patch [30/30] allows to unplug of BUS-less devices using hotplug-handler API.
Converted devices are covered with new hotplug unit-tests, except of:
s390x-*: I have no idea how or means to test it, but code
is close to virtio, so it's converted using virtio template
pvscsi: is broken, so no means to test it
Git tree for testing:
https://github.com/imammedo/qemu/commits/hp_ctrl_conversion_v2
Igor Mammedov (36):
test: virtio-scsi: check if hot-plug/unplug works
test: virtio-serial: check if hot-plug/unplug works
test: libqos: add qpci_plug_device_test() and
qpci_unplug_acpi_device_test()
test: virtio-rng: check if hot-plug/unplug works
test: virtio-net: check if hot-plug/unplug works
test: virtio-blk: check if hot-plug/unplug works
test: usb: move uhci port test code to libqos/usb.c
test: usb: add port test to uhci unit test
test: usb: generic usb device hotplug
test: usb: usb-storage hotplug test
test: usb: usb-uas hotplug test
access BusState.allow_hotplug using wraper qbus_is_hotpluggable()
qdev: do not allow to instantiate non hotpluggable device with
device_add
qdev: HotplugHandler: rename unplug callback to unplug_request
qdev: HotplugHandler: provide unplug callback
qdev: add simple/generic unplug callback for HotplugHandler
qdev: add wrapper to set BUS as HotplugHandler
qdev: drop hotplug check from bus_add_child()
target-i386: ICC bus: drop BusState.allow_hotplug
virtio-pci: drop BusState.allow_hotplug
virtio-serial: convert to hotplug-handler API
virtio-mmio: drop useless bus->allow_hotplug = 0
s390x: drop not used allow_hotplug in event-facility
s390x: convert s390-virtio to hotplug handler API
s390x: convert virtio-ccw to hotplug handler API
scsi: set SCSI BUS itself as default HotplugHandler
scsi: convert pvscsi HBA to hotplug handler API
scsi: convert virtio-scsi HBA to hotplug handler API
scsi: cleanup not used anymore SCSIBusInfo{hotplug,hot_unplug} fields
usb-bot: mark device as non hotpluggable
usb-bot: drop not needed "allow_hotplug = 0"
usb-storage: drop not needed "allow_hotplug = 0"
usb: convert usb-ccid to hotplug handler API
usb: convert usb devices to hotplug handler API
qdev: drop legacy hotplug fields/methods
qdev: HotplugHandler: add support for unplugging BUS-less devices
hw/acpi/piix4.c | 6 +-- hw/char/virtio-serial-bus.c | 20 +++++++--- hw/core/hotplug.c | 11 ++++++ hw/core/qdev.c | 85 ++++++++++++++++++++++++++++-------------- hw/cpu/icc_bus.c | 8 ---- hw/i386/acpi-build.c | 2 +- hw/isa/lpc_ich9.c | 6 +-- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci/pci-hotplug-old.c | 4 +- hw/pci/pcie.c | 4 +- hw/pci/pcie_port.c | 2 +- hw/pci/shpc.c | 4 +- hw/s390x/event-facility.c | 2 - hw/s390x/s390-virtio-bus.c | 12 +++--- hw/s390x/virtio-ccw.c | 17 +++++---- hw/scsi/scsi-bus.c | 24 ++++-------- hw/scsi/virtio-scsi.c | 30 ++++++++++----- hw/scsi/vmw_pvscsi.c | 26 +++++++++---- hw/usb/bus.c | 9 ++++- hw/usb/dev-smartcard-reader.c | 8 +++- hw/usb/dev-storage.c | 4 +- hw/virtio/virtio-mmio.c | 17 +-------- hw/virtio/virtio-pci.c | 3 -- include/hw/hotplug.h | 16 +++++++- include/hw/pci/pcie.h | 4 +- include/hw/pci/shpc.h | 4 +- include/hw/qdev-core.h | 17 +++++---- include/hw/scsi/scsi.h | 2 - qdev-monitor.c | 5 ++- tests/Makefile | 13 ++++--- tests/libqos/pci-pc.c | 49 ++++++++++++++++++++++++ tests/libqos/pci.h | 3 ++ tests/libqos/usb.c | 71 +++++++++++++++++++++++++++++++++++ tests/libqos/usb.h | 17 +++++++++ tests/usb-hcd-ehci-test.c | 50 ++++++++++--------------- tests/usb-hcd-ohci-test.c | 10 ++++- tests/usb-hcd-uhci-test.c | 65 +++++++++++++++++++++++++++++++- tests/usb-hcd-xhci-test.c | 68 ++++++++++++++++++++++++++++++++- tests/virtio-blk-test.c | 49 ++++++++++++++++++------ tests/virtio-net-test.c | 10 +++++ tests/virtio-rng-test.c | 10 +++++ tests/virtio-scsi-test.c | 29 ++++++++++++++ tests/virtio-serial-test.c | 27 ++++++++++++++ 43 files changed, 624 insertions(+), 201 deletions(-) create mode 100644 tests/libqos/usb.c create mode 100644 tests/libqos/usb.h
Signature · 1 line
1.8.3.1