RFC kernel: Add support for poweroff handler call chain
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest16 patches 16 repliesIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
6 of 32 patches have a Reviewed-by or Acked-by.
| Patch | Catalin Marinas | Sebastian Reichel | Mark Salter |
|---|---|---|---|
| 1/16 | |||
| 1/16 | |||
| 2/16 | |||
| 2/16 | |||
| 3/16 | |||
| 3/16 | |||
| 4/16 | |||
| 4/16 | |||
| 5/16 | A-b A-b | ||
| 5/16 | A-b A-b | ||
| 6/16 | |||
| 6/16 | |||
| 7/16 | A-b A-b | ||
| 7/16 | A-b A-b | ||
| 8/16 | |||
| 8/16 | |||
| 9/16 | |||
| 9/16 | |||
| 10/16 | |||
| 10/16 | |||
| 11/16 | |||
| 11/16 | |||
| 12/16 | |||
| 12/16 | |||
| 13/16 | |||
| 13/16 | |||
| 14/16 | |||
| 14/16 | |||
| 15/16 | A-b A-b | ||
| 15/16 | A-b A-b | ||
| 16/16 | |||
| 16/16 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [RFC PATCH 00/16] kernel: Add support for poweroff handler call chain
Various drivers implement architecture and/or device specific means to remove power from the system. For the most part, those drivers set the global variable pm_power_off to point to a function within the driver.
This mechanism has a number of drawbacks. Typically only one scheme to remove power is supported (at least if pm_power_off is used). At least in theory there can be multiple means remove power, some of which may be less desirable. For example, some mechanisms may only power off the CPU or the CPU card, while another may power off the entire system. Others may really just execute a restart sequence or drop into the ROM monitor. Using pm_power_off can also be racy if the function pointer is set from a driver built as module, as the driver may be in the process of being unloaded when pm_power_off is called. If there are multiple poweroff handlers in the system, removing a module with such a handler may inadvertently reset the pointer to pm_power_off to NULL, leaving the system with no means to remove power.
Introduce a system poweroff handler call chain to solve the described problems. This call chain is expected to be executed from the architecture specific machine_power_off() function. Drivers providing system poweroff functionality are expected to register with this call chain. By using the priority field in the notifier block, callers can control poweroff handler execution sequence and thus ensure that the poweroff handler with the optimal capabilities to remove power for a given system is called first.
The poweroff handler is introduced in multiple steps
1) Implement poweroff handler API.
Patch 01/16.
2) Ensure that pm_power_off is only called from machine_restart. Patches 02/16 and 03/16.
3) Implement call to poweroff handler in architecture specific machine_restart code.
Patches 03/16 to 13/16.
4) Convert all drivers to register with poweroff handler instead of setting pm_power_off directly.
Patches 15/16 and 16/16 (examples).
This can be done in two steps: First convert all drivers which can be built as modules, then convert the remaining drivers (possibly after unexporting pm_powr_off).
5) Unexport pm_power_off for all architectures,
and drop it entirely for architectures where it is not really used.
6) [optional] Convert machine specific architecture code to register with poweroff handler instead of setting pm_power_off directly, and remove pm_power_off entirely from the system.
----------------------------------------------------------------
Guenter Roeck (16):
kernel: Add support for poweroff handler call chain
hwmon: (ab8500) Call kernel_power_off instead of pm_power_off
parisc: support poweroff through poweroff handler call chain
arm: support poweroff through poweroff handler call chain
arm64: support poweroff through poweroff handler call chain
avr32: support poweroff through poweroff handler call chain
c6x: support poweroff through poweroff handler call chain
ia64: support poweroff through poweroff handler call chain
metag: support poweroff through poweroff handler call chain
mips: support poweroff through poweroff handler call chain
sh: support poweroff through poweroff handler call chain
unicore32: support poweroff through poweroff handler call chain
x86: support poweroff through poweroff handler call chain x86/xen: support poweroff through poweroff handler call chain power/reset: restart-poweroff: Register with kernel poweroff handler
mfd: palmas: Register with kernel poweroff handler
arch/arm/kernel/process.c | 2 + arch/arm64/kernel/process.c | 2 + arch/avr32/kernel/process.c | 2 + arch/c6x/kernel/process.c | 2 + arch/ia64/kernel/process.c | 2 + arch/metag/kernel/process.c | 2 + arch/mips/kernel/reset.c | 2 + arch/parisc/kernel/process.c | 7 ++- arch/sh/kernel/reboot.c | 2 + arch/unicore32/kernel/process.c | 2 + arch/x86/kernel/reboot.c | 4 ++ arch/x86/xen/enlighten.c | 2 + drivers/hwmon/ab8500.c | 5 ++- drivers/mfd/palmas.c | 30 +++++++------ drivers/parisc/power.c | 3 +- drivers/power/reset/restart-poweroff.c | 24 +++++----- include/linux/mfd/palmas.h | 3 ++ include/linux/reboot.h | 4 ++ kernel/reboot.c | 81 ++++++++++++++++++++++++++++++++++ 19 files changed, 149 insertions(+), 32 deletions(-)