Skip to content

RFC Stage shared dpll configs

Ander Conselvan de Oliveira intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915: Replace some loop through encoders with intel_pipe_has_type()drivers/gpu/drm/i915/intel_display.c+2 -190 replies
2/4drm/i915: Make *_crtc_mode_set work on new_configdrivers/gpu/drm/i915/intel_ddi.c drivers/gpu/drm/i915/intel_display.c+101 -706 replies
3/4drm/i915: Convert shared dpll reference count to a crtc maskdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c+44 -270 replies
4/4drm/i915: Compute clocks and choose DPLLs before disabling crtcsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_ddi.c drivers/gpu/drm/i915/intel_display.c+92 -302 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] [RFC] Stage shared dpll configs

From: Ander Conselvan de Oliveira <[email protected]>

Hi,

This series changes the mode set sequence so that the clock and PLL logic that was done in the *_crtc_mode_set() hooks is done before disabling crtcs. This avoids having to restore the old configuration in the case of failure, since the hardware was never touched.

The changes went through only light testing in a single platform. But I'd like to get comments on the general approach sooner rather than later, hence this RFC.

Thanks,
Ander

Ander Conselvan de Oliveira (4):
drm/i915: Replace some loop through encoders with
intel_pipe_has_type()
drm/i915: Make *_crtc_mode_set work on new_config drm/i915: Convert shared dpll reference count to a crtc mask drm/i915: Compute clocks and choose DPLLs before disabling crtcs

 drivers/gpu/drm/i915/i915_debugfs.c  |   4 +-
 drivers/gpu/drm/i915/i915_drv.h      |  11 +-
 drivers/gpu/drm/i915/intel_ddi.c     |   6 +-
 drivers/gpu/drm/i915/intel_display.c | 346 ++++++++++++++++++++++-------------
 4 files changed, 230 insertions(+), 137 deletions(-)
Signature · 1 line
1.8.3.2