Skip to content

rtc: omap: fixes and power-off feature

Johan Hovold linux-arm-kernel linux-devicetree linux-omap lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest20 patches 28 repliesIn review
  2. v112 patches 40 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20rtc: omap: fix clock-source configurationdrivers/rtc/rtc-omap.c+4 -20 replies
2/20rtc: omap: fix missing wakealarm attributedrivers/rtc/rtc-omap.c+3 -20 replies
3/20rtc: omap: fix interrupt disable at probedrivers/rtc/rtc-omap.c+5 -30 replies
4/20rtc: omap: clean up probe error handlingdrivers/rtc/rtc-omap.c+18 -230 replies
5/20rtc: omap: fix class-device registrationdrivers/rtc/rtc-omap.c+23 -230 replies
6/20rtc: omap: remove unused register-base definedrivers/rtc/rtc-omap.c+0 -20 replies
7/20rtc: omap: use dev_infodrivers/rtc/rtc-omap.c+3 -40 replies
8/20rtc: omap: make platform-device id table constdrivers/rtc/rtc-omap.c+1 -10 replies
9/20rtc: omap: add device abstractiondrivers/rtc/rtc-omap.c+133 -1060 replies
10/20rtc: omap: remove DRIVER_NAME macrodrivers/rtc/rtc-omap.c+3 -50 replies
11/20rtc: omap: add structured device-type infodrivers/rtc/rtc-omap.c+51 -520 replies
12/20rtc: omap: silence bogus power-up reset message at probedrivers/rtc/rtc-omap.c+13 -60 replies
13/20rtc: omap: add helper to read raw bcd timedrivers/rtc/rtc-omap.c+10 -80 replies
14/20rtc: omap: add helper to read 32-bit registersdrivers/rtc/rtc-omap.c+5 -00 replies
15/20rtc: omap: add support for pmic_power_enDocumentation/devicetree/bindings/rtc/rtc-omap.txt drivers/rtc/rtc-omap.c+101 -10 replies
16/20rtc: omap: enable wake-up from power offdrivers/rtc/rtc-omap.c+8 -10 replies
17/20rtc: omap: fix minor coding style issuesdrivers/rtc/rtc-omap.c+27 -190 replies
18/20rtc: omap: add copyright entrydrivers/rtc/rtc-omap.c+1 -00 replies
19/20ARM: dts: am33xx: update rtc-node compatible propertyarch/arm/boot/dts/am33xx.dtsi+1 -10 replies
20/20ARM: dts: am335x-boneblack: enable power off and rtc wake uparch/arm/boot/dts/am335x-boneblack.dts+4 -00 replies

Reviews trailers per patch

4 of 20 patches have a Reviewed-by or Acked-by.

PatchFelipe Balbi
SeriesT-b T-b T-b T-b
1/20R-b
2/20R-b
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/20] rtc: omap: fixes and power-off feature

This series fixes a few issues with the omap rtc-driver, cleans up a bit, adds device abstraction, and finally adds support for the PMIC control feature found in some revisions of this RTC IP block.

Ultimately, this allows for powering off the Beaglebone and waking it up again on RTC alarms.

Changes since v1 include:

- add device abstraction
- add structured device-type info
- fix interrupt disable at probe separately
- register interrupts after class device as before
- add helper to read raw bcd time
- more clean ups
- add copyright entry
- enable pmic control only for Beaglebone Black

I realised that it was better to keep this patch series self-contained and include the device abstraction in it, rather than rely on some patches yet to be posted (contrary to what I proposed in v1). It should now be straight forward to add deferred-probing and regulator support on top of this series instead. [1]

I've kept Felipe's Reviewed-by tags only on the first and last couple of patches which have not changed (in any significant way).

For the record, the new functionality is easily tested on BBB with:

echo +30 >/sys/class/rtc/rtc0/wakealarm; poweroff

There are some patches floating around to add power-off handler call chains [2] as well as an RFC for a generic "poweroff-source" property [3]. Since it is unclear if, when (and through which tree) this will eventually go in, I suggest merging this series as-is now and do the trivial updates to use these new interfaces once the infrastructure is in place.

Johan

[1] https://lkml.org/lkml/2014/10/9/427
[2] https://lkml.org/lkml/2014/10/7/30
[3] https://lkml.org/lkml/2014/10/7/654

Johan Hovold (20):
rtc: omap: fix clock-source configuration
rtc: omap: fix missing wakealarm attribute
rtc: omap: fix interrupt disable at probe
rtc: omap: clean up probe error handling
rtc: omap: fix class-device registration
rtc: omap: remove unused register-base define
rtc: omap: use dev_info
rtc: omap: make platform-device id table const
rtc: omap: add device abstraction
rtc: omap: remove DRIVER_NAME macro
rtc: omap: add structured device-type info
rtc: omap: silence bogus power-up reset message at probe
rtc: omap: add helper to read raw bcd time
rtc: omap: add helper to read 32-bit registers
rtc: omap: add support for pmic_power_en
rtc: omap: enable wake-up from power off
rtc: omap: fix minor coding style issues
rtc: omap: add copyright entry
ARM: dts: am33xx: update rtc-node compatible property
ARM: dts: am335x-boneblack: enable power off and rtc wake up

 Documentation/devicetree/bindings/rtc/rtc-omap.txt |   9 +-
 arch/arm/boot/dts/am335x-boneblack.dts             |   4 +
 arch/arm/boot/dts/am33xx.dtsi                      |   2 +-
 drivers/rtc/rtc-omap.c                             | 540 +++++++++++++--------
 4 files changed, 355 insertions(+), 200 deletions(-)
Signature · 1 line
2.0.4