autobuild-run improvements
Get series with b4
b4 am CAAXf6LVtbsFWBLooB2tN8OzjuR3VK7=QKLf0LdNHDpHz+zRtmg@mail.gmail.comVersions newest first · linked by author and title
- v5 Latest posting 4/40 of 11 patches 0 repliesNew
- v5 posting 3/40 of 11 patches 0 repliesSuperseded
- v5 posting 2/40 of 11 patches 0 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 posting 1/4 | 11 patches | 0 replies | Superseded | |
| v4 | 9 patches | 0 replies | Superseded | |
| v3 | 9 patches | 0 replies | Superseded | |
| v2 | 11 patches | 0 replies | Superseded | |
| v1 | 0 of 8 patches | 0 replies | Superseded |
Patches in v5 posting 4/4 No applies recorded yet
None of the 11 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [Buildroot] [PATCH v5 00/11] autobuild-run improvements
Hi Thomas,
Quoted 30 lines · Thomas Petazzoni
Dear Thomas De Schampheleire,
Quoted 5 lines · Thomas De Schampheleire
Thomas De Schampheleire (11):
scripts: add python module docopt
autobuild-run: use docopt for argument parsing
autobuild-run: add option --make-opts for custom Buildroot options
autobuild-run: use **kwargs to avoid explicit parameter passthroughsQuoted 8 lines
autobuild-run: check-requirements does not need to know the login
details
autobuild-run: set LC_ALL=C to not use locale settings of host machine
autobuild-run: improve the logic to generate build-end.log
autobuild-run: save config.log files for failed package
autobuild-run: extend TODO list
autobuild-run: kill all children on SIGTERM
autobuild-run: catch KeyboardInterrupt in the same way as SIGTERMI've applied your patch series. A few comments, though:
1/ I also applied your two follow-up patches
http://patchwork.ozlabs.org/patch/444865/ and
http://patchwork.ozlabs.org/patch/444866/. As requested in the commit log, the second patch was squashed into the patch adding the support for killing subprocesses.2/ I had to rework patch http://patchwork.ozlabs.org/patch/444866/
becausesubprocess.check_output()doesn't exist in Python 2.6. So I've used a different construct.
Quoted 5 lines
3/ Killing all subprocesses apparently still doesn't work completely
correctly, I got the backtrace of the attached file once when interrupting the autobuild-run script with Ctrl+C, on a system that uses Python 2.6. And the child processes (timeout processes) were still running.
To understand better, some questions:
- you saw this situation once, with Python 2.6, but have been able to successfully stop autobuild run with Ctrl-C with Python 2.6 on other occasions?
- did you happen to use Python 2.7 with these patches on a certain machine? Did you see issues?
In my testing I have been using Python 2.7.
It could be that there is something different in Python 2.6, not sure. I would need to look into this deeper, unless Andr? who seems to be much more knowledgeable about Python has an idea?
Thanks,
Thomas