Skip to content

pty fixes

Peter Hurley linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tty: WARN for attempted set_termios() of pty masterdrivers/tty/pty.c drivers/tty/tty_ioctl.c+4 -20 replies
2/9tty: Move pty-specific set_termios() handling to pty driverdrivers/tty/pty.c drivers/tty/tty_ioctl.c+29 -310 replies
3/9pty: Use spin_lock_irq() for pty_set_termios()drivers/tty/pty.c+2 -40 replies
4/9tty: Use spin_lock_irq() for ctrl_lock when interrupts enableddrivers/tty/n_tty.c drivers/tty/pty.c+6 -90 replies
5/9pty: Don't claim slave's ctrl_lock for master's packet modedrivers/tty/n_tty.c drivers/tty/pty.c+6 -60 replies
6/9pty: Fix packet mode setting racedrivers/tty/pty.c+2 -10 replies
7/9pty: Hold ctrl_lock for packet mode updatesdrivers/tty/pty.c+2 -00 replies
8/9tty: Fix missed wakeup from packet mode status updatedrivers/tty/n_tty.c+5 -40 replies
9/9n_tty: Only process packet mode data in raw modedrivers/tty/n_tty.c+11 -100 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlan Cox
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -next 0/9] pty fixes

Hi Greg,

This series addresses some pecularities of the pty driver, especially set_termios() handling, which is moved into the pty driver proper, and packet mode/ctrl_lock behavior.

Regards,

Peter Hurley (9):
tty: WARN for attempted set_termios() of pty master
tty: Move pty-specific set_termios() handling to pty driver
pty: Use spin_lock_irq() for pty_set_termios()
tty: Use spin_lock_irq() for ctrl_lock when interrupts enabled
pty: Don't claim slave's ctrl_lock for master's packet mode
pty: Fix packet mode setting race
pty: Hold ctrl_lock for packet mode updates
tty: Fix missed wakeup from packet mode status update
n_tty: Only process packet mode data in raw mode

 drivers/tty/n_tty.c     | 39 +++++++++++++++++++------------------
 drivers/tty/pty.c       | 51 ++++++++++++++++++++++++++++++++++++-------------
 drivers/tty/tty_ioctl.c | 34 ++++-----------------------------
 3 files changed, 62 insertions(+), 62 deletions(-)
Signature · 1 line
2.1.1