Skip to content

serial core fixes

Peter Hurley linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10serial: Refactor uart_flush_buffer() from uart_close()drivers/tty/serial/amba-pl011.c drivers/tty/serial/atmel_serial.c drivers/tty/serial/serial-tegra.c +2 more+34 -280 replies
2/10serial: core: Flush ldisc after dropping port mutex in uart_close()drivers/tty/serial/serial_core.c+2 -30 replies
3/10serial: Fix locking for uart driver set_termios() methodDocumentation/serial/driver drivers/tty/serial/serial_core.c+11 -30 replies
4/10tty,serial: Unify UPF_* and ASYNC_* flag definitionsinclude/linux/serial_core.h include/uapi/linux/tty_flags.h+37 -160 replies
5/10tty: Document defunct ASYNC_* bits in uapi headerinclude/uapi/linux/tty_flags.h+5 -44 replies
6/10serial: core: Unwrap >80 char line in uart_close()drivers/tty/serial/serial_core.c+1 -20 replies
7/10serial: core: Remove redundant timeout assignmentsdrivers/tty/serial/serial_core.c+0 -20 replies
8/10serial: core: Colocate crucial structure linkagedrivers/tty/serial/serial_core.c+3 -20 replies
9/10serial: core: Remove extra locking in uart_write()drivers/tty/serial/serial_core.c+2 -10 replies
10/10serial: core: Fix port count when uart_open() errorsdrivers/tty/serial/serial_core.c+15 -100 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchJiri Slaby
1/10
2/10
3/10
4/10
5/10Not-signed-off-by
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -next 00/10] serial core fixes

Hi Greg,

The first 3 patches are picked out from the closing series that was split up; the first 2 patches lay the groundwork for the fixing the locking for the ->set_termios() method.

The 2 UPF_*/ASYNC* patches are to bind the definitions together since userspace only gets one set of definitions, but the code operates as if the definitions are synch'd.

The remainder except the last patch are cleanups; the last patch fixes port count mismatch in uart_open()/uart_close(), which Geert and I discussed a while back. So one less thing on my todo list.

Still on the todo list:
1. Some tty_port flags usage is non-atomic.
2. uart_remove_one_port will happily remove an in-use port since there's no reference counting.
3. fixing autoRTS for omap (so it clears RTS when tiocmset drops RTS)

Regards,

Peter Hurley (10):
serial: Refactor uart_flush_buffer() from uart_close()
serial: core: Flush ldisc after dropping port mutex in uart_close()
serial: Fix locking for uart driver set_termios() method tty,serial: Unify UPF_* and ASYNC_* flag definitions
tty: Document defunct ASYNC_* bits in uapi header
serial: core: Unwrap >80 char line in uart_close()
serial: core: Remove redundant timeout assignments
serial: core: Colocate crucial structure linkage
serial: core: Remove extra locking in uart_write()
serial: core: Fix port count when uart_open() errors

 Documentation/serial/driver       |  6 +++--
 drivers/tty/serial/amba-pl011.c   |  1 +
 drivers/tty/serial/atmel_serial.c | 28 +++++++++++----------
 drivers/tty/serial/serial-tegra.c | 30 +++++++++++-----------
 drivers/tty/serial/serial_core.c  | 52 ++++++++++++++++++++++-----------------
 drivers/tty/serial/timbuart.c     |  2 ++
 include/linux/serial_core.h       | 47 ++++++++++++++++++++++++-----------
 include/uapi/linux/tty_flags.h    | 15 +++++++----
 8 files changed, 110 insertions(+), 71 deletions(-)
Signature · 1 line
2.1.1