Skip to content

6lowpan: Move skb delivery out of IPHC

Martin Townsend linux-bluetooth linux-wpan 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 3 repliesIn review
  2. v3 posting 2/24 patches 1 replySuperseded
  3. v3 posting 1/24 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches4 repliesSuperseded
v15 patches6 repliesSuperseded

Changes in v5 from the cover letter

* Removed unnecessary break statements in lowpan_rcv

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/46lowpan: remove skb_deliver from IPHCinclude/net/6lowpan.h net/6lowpan/iphc.c net/bluetooth/6lowpan.c +1 more+45 -460 replies
2/46lowpan: fix process_data return valuesnet/bluetooth/6lowpan.c net/ieee802154/6lowpan_rtnl.c+4 -40 replies
3/4bluetooth:6lowpan: use consume_skb when packet processed successfullynet/bluetooth/6lowpan.c+4 -30 replies
4/4ieee802154: 6lowpan: rename process_data and lowpan_process_datainclude/net/6lowpan.h net/6lowpan/iphc.c net/bluetooth/6lowpan.c +1 more+29 -230 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexander AringJukka Rissanen
SeriesA-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 bluetooth-next 0/4] 6lowpan: Move skb delivery out of IPHC

This series moves skb delivery out of IPHC and into the receive routines of both bluetooth and 802.15.4. The reason is that we need to support more (de)compression schemes in the future. It also means that calling lowpan_process_data now only returns error codes or 0 for success so this has been cleaned up. The final patch then renames occurences of lowpan_process_data and process_data to something more meaningful.

v1 -> v2

* Handle freeing of skb in lowpan_give_skb_to_devices for 802.15.14
* Added another skb_consume in bluetooth code for uncompressed IPv6 headers
* Added missing skb_consume for local_skb for bluetooth in compreesed IPv6 header path
* Combine patch 4 into 1.

v2 -> v3

* Ensure error codes aren't returned in the bluetooth skb delivery function.
* In lowpan_give_skb_to_devices return NET_RX_DROP when the first call to netif_rx fails.

v3 -> v4

* Fixed incorrect frag return handling due to refactoring skb_deliver.

v4 -> v5

* Removed unnecessary break statements in lowpan_rcv

Martin Townsend (4):
6lowpan: remove skb_deliver from IPHC
6lowpan: fix process_data return values
bluetooth:6lowpan: use consume_skb when packet processed successfully
ieee802154: 6lowpan: rename process_data and lowpan_process_data

 include/net/6lowpan.h         | 12 ++++-----
 net/6lowpan/iphc.c            | 42 +++++++++---------------------
 net/bluetooth/6lowpan.c       | 36 +++++++++++++++++---------
 net/ieee802154/6lowpan_rtnl.c | 60 ++++++++++++++++++++++++++-----------------
 4 files changed, 78 insertions(+), 72 deletions(-)
Signature · 1 line
1.9.1