Skip to content

multiwrite patches for 2.2

Peter Lieven qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 16 repliesIn review
  2. v26 patches 6 repliesSuperseded
  3. v14 patches 12 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6block: add accounting for merged requestsblock.c block/accounting.c block/qapi.c +3 more+22 -22 replies
2/6block: introduce bdrv_runtime_optsblock.c+33 -52 replies
3/6block: add a knob to disable multiwrite_mergeblock.c block/qapi.c hmp.c +4 more+27 -16 replies
4/6hw/virtio-blk: add a constant for max number of merged requestshw/block/virtio-blk.c+3 -12 replies
5/6block: add qemu-iotest for write-merge parametertests/qemu-iotests/109 tests/qemu-iotests/109.out tests/qemu-iotests/group+136 -02 replies
6/6block: fix qemu-iotest reference output for test 067tests/qemu-iotests/067.out+5 -51 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMax ReitzStefan Hajnoczi
1/6R-b
2/6R-b R-b
3/6R-b
4/6R-b R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCHv3 0/6] multiwrite patches for 2.2

This adds some preparing patches for upcoming multiwrite modifications. I will leave the dangerous patches for after 2.2 release.

Due to oversized lines in the iotest output please pull from:
[email protected]:plieven/qemu.git -b multiwrite_22_v3

v2->v3: - Removed statistic output for merged read requests [Eric]
- Fixed double s-o-b line in Patch 3 [Eric]
- Fixed iotest in Patch 5 [Max]. Renamed from 108 to 109.

v1->v2: - incorporated Max's comments, but did not display the default
value for write merging (Patch 3) in the HMP since we do not do it for other commands. I would change this when the default changes.
- added an iotest for the write-merging cmdline parameter [Max]
- fixed iotest 067 output

Peter Lieven (6):
block: add accounting for merged requests
block: introduce bdrv_runtime_opts
block: add a knob to disable multiwrite_merge hw/virtio-blk: add a constant for max number of merged requests
block: add qemu-iotest for write-merge parameter
block: fix qemu-iotest reference output for test 067

 block.c                    |   49 +++++++++++++++++--
 block/accounting.c         |    7 +++
 block/qapi.c               |    2 +
 hmp.c                      |    8 +++-
 hw/block/virtio-blk.c      |    4 +-
 include/block/accounting.h |    3 ++
 include/block/block_int.h  |    1 +
 qapi/block-core.json       |   17 ++++++-
 qemu-options.hx            |    1 +
 qmp-commands.hx            |    2 +
 tests/qemu-iotests/067.out |   10 ++--
 tests/qemu-iotests/109     |  113 ++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/109.out |   68 ++++++++++++++++++++++++++
 tests/qemu-iotests/group   |    1 +
 14 files changed, 272 insertions(+), 14 deletions(-)
 create mode 100755 tests/qemu-iotests/109
 create mode 100644 tests/qemu-iotests/109.out
Signature · 1 line
1.7.9.5