Skip to content

ieee802154: rework receive handling

Alexander Aring linux-wpan 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 1 replyIn review
  2. v116 patches 2 repliesSuperseded

changes since v2 from the cover letter

- correct ieee802154 instead ieee80211 in patch 04/16 ("mac802154: rx:
document ieee802154_rx() context requirement")
- reword complete commit message of patch 04/16 ("mac802154: rx: document ieee802154_rx() context requirement")
- fix && instead || in patch 13/16 ("ieee802154: add valid psdu length helper")
- make patch 13/16 ("ieee802154: add valid psdu length helper") more human readable to check start at first end then end interval. Instead end <-> start checking.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16mac802154: tx: use put_unaligned_le16 for copy crcnet/mac802154/tx.c+3 -20 replies
2/16ieee802154: drivers: use dev_alloc_skbdrivers/net/ieee802154/at86rf230.c drivers/net/ieee802154/cc2520.c drivers/net/ieee802154/mrf24j40.c+3 -30 replies
3/16mac802154: rx: use tasklet instead workqueueinclude/net/mac802154.h net/mac802154/ieee802154_i.h net/mac802154/iface.c +2 more+47 -410 replies
4/16mac802154: rx: document ieee802154_rx() context requirementnet/mac802154/rx.c+2 -00 replies
5/16mac802154: rx: move receive handling into rx.cnet/mac802154/ieee802154_i.h net/mac802154/iface.c net/mac802154/monitor.c +1 more+214 -2140 replies
6/16mac802154: tx: remove monitor receive while xmitnet/mac802154/ieee802154_i.h net/mac802154/rx.c net/mac802154/tx.c+2 -40 replies
7/16mac802154: rx: rename remove mac802154_subif_rxnet/mac802154/rx.c+3 -90 replies
8/16mac802154: rx: move skb->protocol settingnet/mac802154/rx.c+4 -10 replies
9/16mac802154: rx: add CHECKSUM_UNNECESSARYnet/mac802154/rx.c+2 -00 replies
10/16mac802154: rx: add monitor pkt_type informationnet/mac802154/rx.c+1 -00 replies
11/16mac802154: rx: move skb_reset_mac_headernet/mac802154/rx.c+3 -20 replies
12/16mac802154: rx: move rcu lockingnet/mac802154/rx.c+4 -40 replies
13/16ieee802154: add valid psdu length helperinclude/linux/ieee802154.h+11 -00 replies
14/16at86rf230: use ieee802154_is_valid_psdu_len helperdrivers/net/ieee802154/at86rf230.c+8 -180 replies
15/16at86rf230: improve receive handlingdrivers/net/ieee802154/at86rf230.c+3 -70 replies
16/16mac802154: rx: change naming conventionnet/mac802154/rx.c+17 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 bluetooth-next 00/16] ieee802154: rework receive handling

This patch serie improves and cleanups the receive handling. Instead workqueue we use a tasklet now for parsing frames. The first patch is a fix for using put_unaligned_le16 to copy checksum in skb data which was reported by Marcel Holtmann.

Other patches are cleanups for preparing further patches to introduce a frame parsing like mac80211. We don't change the printout function to netdev_foo now because the most code will be replaced by the new frame parsing implementation.

changes since v2:
- correct ieee802154 instead ieee80211 in patch 04/16 ("mac802154: rx:
document ieee802154_rx() context requirement")
- reword complete commit message of patch 04/16 ("mac802154: rx: document ieee802154_rx() context requirement")
- fix && instead || in patch 13/16 ("ieee802154: add valid psdu length helper")
- make patch 13/16 ("ieee802154: add valid psdu length helper") more human readable to check start at first end then end interval. Instead end <-> start checking.

Alexander Aring (16):
mac802154: tx: use put_unaligned_le16 for copy crc
ieee802154: drivers: use dev_alloc_skb
mac802154: rx: use tasklet instead workqueue
mac802154: rx: document ieee802154_rx() context requirement
mac802154: rx: move receive handling into rx.c
mac802154: tx: remove monitor receive while xmit
mac802154: rx: rename remove mac802154_subif_rx
mac802154: rx: move skb->protocol setting
mac802154: rx: add CHECKSUM_UNNECESSARY
mac802154: rx: add monitor pkt_type information
mac802154: rx: move skb_reset_mac_header
mac802154: rx: move rcu locking
ieee802154: add valid psdu length helper
at86rf230: use ieee802154_is_valid_psdu_len helper
at86rf230: improve receive handling
mac802154: rx: change naming convention

 drivers/net/ieee802154/at86rf230.c |  32 ++---
 drivers/net/ieee802154/cc2520.c    |   2 +-
 drivers/net/ieee802154/mrf24j40.c  |   2 +-
 include/linux/ieee802154.h         |  11 ++
 include/net/mac802154.h            |   1 +
 net/mac802154/ieee802154_i.h       |   9 +-
 net/mac802154/iface.c              | 186 -------------------------
 net/mac802154/main.c               |  30 ++++
 net/mac802154/monitor.c            |  27 ----
 net/mac802154/rx.c                 | 279 +++++++++++++++++++++++++++++++------
 net/mac802154/tx.c                 |   7 +-
 11 files changed, 296 insertions(+), 290 deletions(-)
Signature · 1 line
2.1.2